calendar icon indicating copy to clipboard operation
calendar copied to clipboard

Accessibility: "+ New Calendar", the + should be an icon and not in text

Open JuliaKirschenheuter opened this issue 3 years ago • 9 comments

Part of https://github.com/nextcloud/calendar/issues/3540

JuliaKirschenheuter avatar Feb 17 '22 14:02 JuliaKirschenheuter

@nimishavijay @GretaD @ChristophWurst should we remove this "+" inside of a title? We have already the action button on the right side image

JuliaKirschenheuter avatar Feb 18 '22 07:02 JuliaKirschenheuter

@jancborchardt ^

ChristophWurst avatar Feb 18 '22 08:02 ChristophWurst

Yes, really good point! I think it could be an icon on the left and then we don't need the button on the right

similar to Deck image

nimishavijay avatar Feb 18 '22 14:02 nimishavijay

Bildschirmfoto von 2022-02-18 17-13-28

^ Deck only requires a name for the creation, in Calendar we have different types of Calendars

Bildschirmfoto von 2022-02-18 17-13-54

hence doing it like deck isn't possible because we need the menu. unless you are okay with anchoring the menu on the left, as opposed to all other existing navigation action menus that sit on the right.

ChristophWurst avatar Feb 18 '22 16:02 ChristophWurst

I would say creating a normal calendar is a more common task than the other two, so we can put those in a menu, and on clicking the navigation item a normal calendar would be created.

Made a super quick mockup for this (ignore the icons in the menu) image

"Add calendar" would create a normal calendar, other 2 options can be accessed from the 3-dot menu What do you think? also cc @jancborchardt if there's any other feedback

nimishavijay avatar Feb 18 '22 16:02 nimishavijay

Small adjustment after call with @nimishavijay:

  • Whole "Add calendar" row is clickable
  • Menu has the 3 entries, and is centered below the click area
  • "+" is an icon on the left image

Does that work @ChristophWurst? This was also the originally intended design for the "New calendar" section in the first place, but then for some reason (component limitation?) the action menu on the right was used.

jancborchardt avatar Feb 23 '22 11:02 jancborchardt

Last state: https://github.com/nextcloud/nextcloud-vue/pull/2555#issuecomment-1077514959

JuliaKirschenheuter avatar May 05 '22 09:05 JuliaKirschenheuter

So we need to finish https://github.com/nextcloud/nextcloud-vue/pull/2587.

ChristophWurst avatar May 05 '22 12:05 ChristophWurst

This ticket is blocked https://github.com/nextcloud/calendar/pull/4082 Calendar should be bumped to the newer (up to v.6) version

JuliaKirschenheuter avatar Aug 17 '22 09:08 JuliaKirschenheuter

Might already be fixed by #4539.

Ref #4525

st3iny avatar Oct 08 '22 12:10 st3iny

already be fixed by https://github.com/nextcloud/calendar/pull/4539.

Ref https://github.com/nextcloud/calendar/issues/4525

JuliaKirschenheuter avatar Oct 12 '22 10:10 JuliaKirschenheuter