calendar icon indicating copy to clipboard operation
calendar copied to clipboard

Fix attendees avatars

Open tcitworld opened this issue 4 years ago • 2 comments

Works when you add new attendees, but still needs work to fetch existing ones when loading the event editor.

Also fixes useless calls to user status if attendee if not an user.

Fixes https://github.com/nextcloud/calendar/issues/3099

tcitworld avatar May 20 '21 18:05 tcitworld

Codecov Report

Patch coverage: 29.62% and project coverage change: +0.01 :tada:

Comparison is base (8e98722) 22.59% compared to head (5662542) 22.60%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3101      +/-   ##
============================================
+ Coverage     22.59%   22.60%   +0.01%     
- Complexity      373      374       +1     
============================================
  Files           236      236              
  Lines         11475    11495      +20     
  Branches       2149     2150       +1     
============================================
+ Hits           2593     2599       +6     
- Misses         8882     8896      +14     
Flag Coverage Δ
javascript 14.04% <29.62%> (+0.01%) :arrow_up:
php 63.93% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/Editor/Invitees/InviteesList.vue 0.00% <0.00%> (ø)
...rc/components/Editor/Invitees/InviteesListItem.vue 0.00% <0.00%> (ø)
.../components/Editor/Invitees/InviteesListSearch.vue 0.00% <0.00%> (ø)
...c/components/Editor/Invitees/OrganizerListItem.vue 0.00% <ø> (ø)
src/store/contacts.js 70.00% <47.05%> (-30.00%) :arrow_down:

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 20 '21 18:05 codecov[bot]

Hello! I would like to ask. I am currently working on attachments in a parallel branch https://github.com/nextcloud/calendar/pull/4251#discussion_r919033226 . According to the CalDAV specification, we can use our own parameters: ex X-NC-ATTENDEE-PHOTO (May be it will be usefull)

So, can the avatar url parameter be passed when adding a user? In my case its look like this in .ics file: image

sazanof avatar Aug 01 '22 13:08 sazanof