bookmarks icon indicating copy to clipboard operation
bookmarks copied to clipboard

fix service worker

Open szaimen opened this issue 1 year ago • 2 comments

Found via https://github.com/search?q=org%3Anextcloud+noRewrite&type=code

Close https://github.com/nextcloud/bookmarks/issues/1078

Disclaimer: I wasn't able to test this but I think it should work.

Signed-off-by: szaimen [email protected]

szaimen avatar Sep 03 '22 18:09 szaimen

Codecov Report

Merging #1889 (145a103) into master (b119d71) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1889   +/-   ##
=========================================
  Coverage     43.97%   43.97%           
  Complexity     1453     1453           
=========================================
  Files            98       98           
  Lines          5706     5706           
=========================================
  Hits           2509     2509           
  Misses         3197     3197           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 03 '22 18:09 codecov-commenter

ping @marcelklehr

szaimen avatar Sep 09 '22 08:09 szaimen

@marcelklehr I think this should work now. However not really sure how to test since my test instance uses a self-signed certificate which makes service-workers unsupported by definition.

szaimen avatar Sep 26 '22 11:09 szaimen

Tested and can confirm it works! Thanks :)

marcelklehr avatar Sep 26 '22 14:09 marcelklehr