backup icon indicating copy to clipboard operation
backup copied to clipboard

Purge external storage and preserve dependencies

Open Vrumf0ndel opened this issue 3 years ago • 5 comments

Based on previous implementation of @ArtificialOwl.

Fixes #176

Vrumf0ndel avatar Mar 18 '22 18:03 Vrumf0ndel

@ArtificialOwl could you please review the PR for purge improvement of external storage? thanks in advance.

Vrumf0ndel avatar Mar 29 '22 19:03 Vrumf0ndel

I believe this logic is going to result in the same orphaning problem we already see. Please see Pull #219

jxmx avatar Apr 02 '22 18:04 jxmx

The purge logic of my PR is quite simple: It just sorts the external points from newest to oldest, keeps the newest x points as configured, and in case of differential points it remembers the related parents of that items. Then the remaining items are deleted one after another if they are not in the "parents to remember" list. So the needed parent items are save from purging process. I have a separate NC test instance and tested it extensively, also it runs in my productive instance. @jxmx What are your indications it would result in same orphaning problem as before?

Vrumf0ndel avatar Apr 04 '22 11:04 Vrumf0ndel

I see the logic now. Are you going to replace my #183 with the same logic then?

jxmx avatar Apr 04 '22 12:04 jxmx

Hello @Vrumf0ndel

Thanks for your contribution, code looks good. Can you please rebase it on master, or do you need #151 ?

ArtificialOwl avatar Sep 05 '22 12:09 ArtificialOwl