nextcloud
Workflow-Chaining not working
Hello!
I have the following test-setup with two workflows and I am trying to achieve a two-tiered approval workflow as described in the documentation.
The first step is working well. Members of the group "Freigabeanforderer" can request their approval and the members of the group "Inhaltliche Rechnungsfreigabe" get the request to act upon that.
However, after the approval by "Inhaltliche Rechnungsfreigabe", the second workflow does not seem to be triggered correctly.
In this case, I have three different files and I am logged in as a member of the group that can approve or decline files in the first workflow. One file was rejected, which is shown correctly (indicated by the green symbol). I approved the other two files which should then be handed on to the second workflow (which seems to be working partly, as the symbol with the three dots indicates that there is an approval pending). However, memers of the group "Kaufmännische Rechnungsfreigabe" cannot see the file. It is not shared with the group.
As the owner of the file, I can see that the file is only shared with the first group of users that can approve, not the second.
If the owner of the file shares the file with the second group manually, they can approve or reject the file, but they do not get the notification.
Expected behavior would be that the group membership is automatically assigned.
I am using Nextcloud Hub II (23.0.0) with the version of the approval-addon that is published on the app market.
Thanks!
For me, the invisible tags are suddenly no longer consistently displayed for the involved participants (NC 22.2.2).
@osm-frasch What do you mean by displayed? The invisible tags are supposed to be only visible by admins. Not matter what role a user plays in an approval workflow, one doesn't see invisible tags if one's not an admin.
@xenophil90 Thanks for the issue. The sharing was not done because when chaining, the app considers that the file owner is the one who requests with the 2nd rule so if this user is not authorized by this rule, nothing happens.
This is now fixed by removing the authorization check when a request comes from a tag assignment (manual or automatically done in a chain). This check made no sense if invisible tags are used because nobody can manually assign them except admins.
Could you try the latest nightly build (v1.0.10-1-nightly)?
- One problem remains: if the rules are using classic tags, there is no more check and anybody can request by manually assigning a pending tag. What do you think about that downside?
- There is another minor problem actually: If an approval is requested twice one the same file with the same rule (for whatever reason, after it has been accepted/rejected for example), the file won't be shared the second time. It might not be such a big deal but could be annoying in some cases. I'll see if I can find a nice way to solve that.
@eneiluj Sorry, I guess I didn't realize that before. In my test environment, one participant is admin.
I agree with @xenophil90. Got the same bug here. Sorry for asking. @eneiluj But does this bug still exist? Is there any progress on this? Is there any more info needed? In my system it still exists: I am on NC 22.2.2, PHP: 7.3.16, Approval: 1.0.9.
@osm-frasch Have you tried v1.0.10-1-nightly?
Sorry - no. I can't. We only have a productive environment. So I have to wait until this becomes public in the NC App Store.
Is there already positive feedback from other participants on v1.0.10-1-nightly?
hi. same bug in my environment. i tested v1.0.10-1-nightly (with NC 23.04). the result is:
- now users set for 2nd approval receive the notification
- still, it needs to put the file into a shared folder, otherwise by clicking onto the "approval requested" notification the user (still speaking of the 2nd approval) receives a "can't find that file" error. regards
@rmuzzini Could you try with v1.0.10-2-nightly? I fixed the sharing issue. The "sharing" permissions were needed to be able to reshare the file in a chained context.
I'll publish a release if this works better now.
Sorry all about the slow pace regarding the development of this app. It's tough to find some time for this app. It will still be maintained during a long time.
@eneiluj : tested approval-1.0.10-3-nightly @ NC23.0.6. all works fine, now: notifications, permissions, approvals as expected. great work! if you need other test, i.e. on NC24, let me know. regards.
@rmuzzini I can't see any reason why it would not work on NC 24. I already extensively used it on NC 25-dev. Thanks a lot for your feedback! v1.0.10 is coming.
Let's keep this issue open until someone else confirms this issue is gone with v1.0.10 .