app-certificate-requests icon indicating copy to clipboard operation
app-certificate-requests copied to clipboard

revoke summarai.crt

Open kyteinsky opened this issue 1 year ago • 16 comments
trafficstars

kyteinsky avatar Sep 09 '24 13:09 kyteinsky

needs revocation as usual

nickvergessen avatar Sep 09 '24 14:09 nickvergessen

Hi, sorry I don't understand what I should do, if it was meant for me? Also, the previous cert/key was not used to register any app.

kyteinsky avatar Sep 09 '24 15:09 kyteinsky

No, that's for Matthieu or the sysadmin doing it :P

nickvergessen avatar Sep 09 '24 15:09 nickvergessen

needs revocation as usual

if I run docker compose run php ./bin/certmanager certificate:revoke 728, I get The pull request need to have only a file: the certificate file.

Is that correct?

camilasan avatar Sep 09 '24 18:09 camilasan

I think you need to revoke 684 which is the original PR: https://github.com/nextcloud/app-certificate-requests/pull/684

nickvergessen avatar Sep 09 '24 20:09 nickvergessen

The revoke command was projected to revoke an appid.

At this PR have two actions: revoke and create a new cert.

To work with this tool, will be necessary two PR (the quick way, a PR revoking and a PR adding a new app). To use this PR will be necessary implement a new command, i.e. certificate:rename to consider 3 files changed by PR.

vitormattos avatar Sep 10 '24 02:09 vitormattos

I can convert this PR to just add summary_bot if you wish to revoke #684

kyteinsky avatar Sep 10 '24 07:09 kyteinsky

I think you need to revoke 684 which is the original PR: #684

this throws this error: This PR need to modify a csr file. The status of this PR is: added

camilasan avatar Sep 10 '24 12:09 camilasan

I can convert this PR to just add summary_bot if you wish to revoke https://github.com/nextcloud/app-certificate-requests/pull/684

Might be easier to do both things in separate PRs:

  1. Remove summarai in this PR and revoke it
  2. New PR to request summary_bot

nickvergessen avatar Sep 10 '24 13:09 nickvergessen

This PR need to modify a csr file. The status of this PR is: added

To revoke a csr, is necessary a change of csr file. The PR 684 is adding a new csr file and this already was made. The PR 684 can't be used to revoke a certificate.

A way that solve this is:

  • change this PR to have only a file creating the summari_bot to unlock the flow to generate the crt file
  • Create a new PR only deleting (revoke) the summari.crt

vitormattos avatar Sep 10 '24 13:09 vitormattos

summary_bot.csr is here: #729

kyteinsky avatar Sep 10 '24 16:09 kyteinsky

kind pingu

kyteinsky avatar Sep 18 '24 10:09 kyteinsky

when trying to revoke this PR with certificate:revoke 728, I am getting: The pull request need to have only a file: the certificate file

Maybe the certificate file was not supposed to be deleted in this PR?

camilasan avatar Sep 18 '24 10:09 camilasan

@kyteinsky could you also remove the .csr file?

camilasan avatar Sep 18 '24 10:09 camilasan

And the folder too?

kyteinsky avatar Sep 18 '24 10:09 kyteinsky

And the folder too?

just the files.

camilasan avatar Sep 18 '24 10:09 camilasan

@GretaD did this?

nickvergessen avatar Oct 22 '24 07:10 nickvergessen

@GretaD did this?

yes, here 8d7a0006ccdbf3ea0d9cdbfe783875416b49f683, sorry, forgot to close the ticket

GretaD avatar Oct 22 '24 07:10 GretaD