android icon indicating copy to clipboard operation
android copied to clipboard

i18n: Text strings for setting status

Open Valdnet opened this issue 3 years ago • 8 comments
trafficstars

The following text strings:

  • In 1 hour
  • In 30 minutes

obraz

Should be changed to:

  • 1 hour
  • 30 minutes

They are not present in the application code, which can be thought to be downloaded from Android system.

They are translated into Polish as:

  • Za 1 godzinÄ™
  • Za 30 minut

Which contradicts the given function. It should be correct:

  • Przez 1 godzinÄ™
  • Przez 30 minut

obraz

Valdnet avatar Jan 25 '22 13:01 Valdnet

@tobiasKaminsky do you know where these strings come from?

AlvaroBrey avatar Jan 25 '22 14:01 AlvaroBrey

I think from here: https://github.com/nextcloud/android/blob/7db8069ff06e72e9a42831d485ae7deeaf34b5f6/src/main/java/com/owncloud/android/ui/adapter/PredefinedStatusViewHolder.kt#L46

tobiasKaminsky avatar Jan 26 '22 14:01 tobiasKaminsky

If the issue is still persisting may I work on it ?

simunde avatar Jan 26 '22 15:01 simunde

@simunde If you want to fix it, commit then add to PR and wait for approval 😉.

Valdnet avatar Jan 27 '22 08:01 Valdnet

@tobiasKaminsky I am working on this issue and when I change from In 1 hour to 1 hour the Polish translation will change from Za 1 godzinÄ™ to 1 godzinÄ™ not Przez 1 godzinÄ™. Is this correct or I am missing something?

hmncube avatar Nov 30 '22 08:11 hmncube

Not sure about polish translation. Maybe @Valdnet can help out?

tobiasKaminsky avatar Nov 30 '22 10:11 tobiasKaminsky

The text string is most likely from Android. Not present in Transifex translation. I am in favor of the proposal given by @hmncube.

Valdnet avatar Dec 01 '22 19:12 Valdnet

Fine with me. We have same in web ui.

tobiasKaminsky avatar Jan 17 '23 13:01 tobiasKaminsky

Hi, is this issue still available? If so, can I please be assigned to it?

SamGreenwood04 avatar Oct 10 '24 04:10 SamGreenwood04

I’m stepping away from this issue as I’ve had trouble getting the project to build successfully. Can I please be released from it for someone else to take over? Thanks!

SamGreenwood04 avatar Oct 24 '24 09:10 SamGreenwood04