android icon indicating copy to clipboard operation
android copied to clipboard

Ability to edit instant upload settings before enabling it

Open Spielmops opened this issue 4 years ago • 24 comments

If I want a folder to be a member of "instant uplad", I have to edit the settings to my preference. But to edit this settings, I have to enable instant upload. In that moment the app starts to work on that upload with the standart settings. And when I am ready with editing, the app starts that upload too. Imho it would be better to first change the settings and then allow the app to work with that settings.

Spielmops

Spielmops avatar May 16 '21 09:05 Spielmops

You mean a standard, detected folder? That offers the setup on the 3 dot menu where you can activate and it won't trigger the upload right away AFAIK, no?

AndyScherzinger avatar May 16 '21 15:05 AndyScherzinger

But to edit this settings, I have to enable instant upload

Spielmops avatar May 16 '21 18:05 Spielmops

Like I said, IMHO you don't if you go through the 3 dot menu und not click on the cloud icon.

AndyScherzinger avatar May 16 '21 19:05 AndyScherzinger

Like I said: you can not change anything, if you don't switch the auto-upload to "on". Did you ever try that yourself?

Spielmops

Spielmops avatar May 18 '21 18:05 Spielmops

First: thanks for all the work on the app, one should not just complain but also appreciate the hard work that goes into these pieces of software :)

On topic: I can confirm everything is greyed out untill you enable it. When you go to the three dots, switch autoupload on, change settings, and only then click 'save' to activate it, it won't start uploading before you click 'save'? That is my guess. But it is not very intuitive. Maybe make the controls available, that way it feels more intuitive :)

droppiq avatar May 19 '21 21:05 droppiq

That is my guess

That is correct

Maybe make the controls available, that way it feels more intuitive :)

Where we had reports that "changes don't work" because people edit a auto upload config but didn't activate it...

AndyScherzinger avatar May 19 '21 22:05 AndyScherzinger

Sorry guys, you don't seem to use this app. If I switch autoupload for a folder to "on", then the upload starts with the standart upload-folder.

Spielmops

Spielmops avatar May 20 '21 19:05 Spielmops

If I switch autoupload for a folder to "on", then the upload starts with the standard upload-folder.

How do you switch it on? Via the cloud icon or within the folder's setting dialog?

AndyScherzinger avatar May 20 '21 20:05 AndyScherzinger

Sorry guys, you don't seem to use this app.

  1. please don't make assumptions about people you don't know
  2. fun fact: I wrote that UI
  3. see 1. I do use it but with default-settings-always

AndyScherzinger avatar May 20 '21 20:05 AndyScherzinger

That is my guess

That is correct

Maybe make the controls available, that way it feels more intuitive :)

Where we had reports that "changes don't work" because people edit a auto upload config but didn't activate it...

I can imagine different people having a different feel for what is intuitive :) Maybe as a middleground show a text in the settings menu stating: AutoUpload will not start before clicking 'save'. or something along those lines? Minimal effort for making a lot clear.

droppiq avatar May 20 '21 20:05 droppiq

It has still been a different case.... people edited the config while keeping it disabled and reported that "nothing happened" (because well, you didn't active the auto upload). So simply saving it isn't enough ;)

AndyScherzinger avatar May 20 '21 20:05 AndyScherzinger

I tap onto the 3-dot-icon and get a dialog: "hide folder" or "settings" (einrichten). I tap on "setting" and get the "settings for auto-upload"-dialog, where I can change nothing, because everything is greyed out. The remote-folder is set to "instant-upload/". If I want to change the remote-folder, I have to put the switch in the top right corner to on. And while I change the remote-folder, I can see in the status-line, that the app is already uploading the files into the preset folder.

Spielmops

PS: if others can guess then I can assume ;-)

Spielmops avatar May 22 '21 12:05 Spielmops

It has still been a different case.... people edited the config while keeping it disabled and reported that "nothing happened" (because well, you didn't active the auto upload). So simply saving it isn't enough ;)

To recap: I'm not suggesting to change anything in the current workflow. Just to add a single sentence right above the 'save' button with the text I suggested. This in an effort to make people confident that turning on AutoUpload will not start uploading while one is still making changes before one hits 'save'. Would make it much clearer in MHO :)

droppiq avatar May 22 '21 13:05 droppiq

I tap onto the 3-dot-icon and get a dialog: "hide folder" or "settings" (einrichten). I tap on "setting" and get the "settings for auto-upload"-dialog, where I can change nothing, because everything is greyed out. The remote-folder is set to "instant-upload/". If I want to change the remote-folder, I have to put the switch in the top right corner to on. And while I change the remote-folder, I can see in the status-line, that the app is already uploading the files into the preset folder.

Spielmops

PS: if others can guess then I can assume ;-)

This is exactly my situation, its so dodgy and painful.

StarSmasher44 avatar May 24 '21 16:05 StarSmasher44

I tap onto the 3-dot-icon and get a dialog: "hide folder" or "settings" (einrichten). I tap on "setting" and get the "settings for auto-upload"-dialog, where I can change nothing, because everything is greyed out. The remote-folder is set to "instant-upload/". If I want to change the remote-folder, I have to put the switch in the top right corner to on. And while I change the remote-folder, I can see in the status-line, that the app is already uploading the files into the preset folder.

That would be an issue, yes and needs to be fixed 👍

PS: if others can guess then I can assume ;-)

Due to the ";-)" I take this with a grain of salt :-), else I'd say no, since that would lead to bad citizenship here.

This in an effort to make people confident that turning on AutoUpload will not start uploading while one is still making changes before one hits 'save'. Would make it much clearer in MHO :)

According to @Spielmops this isn't the case. So we first need to investigate when a change is actually persisted and triggered

AndyScherzinger avatar May 25 '21 10:05 AndyScherzinger

And 3 seconds of testing what is being said will confirm this easily, and solves this back & forth altogether.

You cannot change auto upload settings without turning it on first. Turning it on will make it activate using the (default) settings provided, which are obviously wrong when you wish to change save location. And all photos in the folder will be triggered to upload under bad settings.

My workaround has been to disable wifi & internet, turn on auto upload, make changes to config, then save and turn back on wifi. But obviously it would be better to trigger only on saving a new configuration, as the cleanup from this is irritating.

You can easily see where the logic fails here too.. Turn on a default config, to then change the default config which is now already running.

That's without mentioning how slow auto upload as a whole works, or how 7000+ photos is now taking 2 full days (& counting) and 600 app restarts and freezes later, we'll save that for another time.

nssatlantis avatar May 25 '21 11:05 nssatlantis

And 3 seconds of testing what is being said will confirm this easily, and solves this back & forth altogether.

Please stop such communication since this is just mocking devs!

You cannot change auto upload settings without turning it on first. Turning it on will make it activate using the (default) settings provided, which are obviously wrong when you wish to change save location. And all photos in the folder will be triggered to upload under bad settings.

Also regarding both quotes. I just tested it and if I go through the settings, activate via the switch on the settings dialog then no upload it triggered before I hit the save button. Also cc @Spielmops since this also conflicts with your statements. I checked the code and only when the save button has been hit the background job to upload files gets triggered. So neither my tests on my phone nor looking at the code indicate that this is triggered when you hit the switch on the settings screen! cc also @tobiasKaminsky

AndyScherzinger avatar May 25 '21 13:05 AndyScherzinger

I tap onto the 3-dot-icon and get a dialog: "hide folder" or "settings" (einrichten). I tap on "setting" and get the "settings for auto-upload"-dialog, where I can change nothing, because everything is greyed out. The remote-folder is set to "instant-upload/". If I want to change the remote-folder, I have to put the switch in the top right corner to on. And while I change the remote-folder, I can see in the status-line, that the app is already uploading the files into the preset folder.

Spielmops

PS: if others can guess then I can assume ;-)

This is the exact same thing I try to explain, there is no difference in the way it works as it is described here. I have the exact same issue. But if you say the code doesn't work that way I am willing to believe it. Is it possible, however.. That there is an automatic function that checks for auto-upload stuff that was running at the same moment as I enabled it?

StarSmasher44 avatar May 25 '21 17:05 StarSmasher44

That there is an automatic function that checks for auto-upload stuff that was running at the same moment as I enabled it?

There is one edge case I could think of. If you have a new device linked to an Google account which you used on another device before and there activated auto upload for a folder that also exists on the new device and open the app the first time then it might trigger an upload maybe. I only took a short look at the code so might be wrong while I did 2 tests on rather exotic image folders and none triggered an upload when hitting the switch but only started instantly when I hit the save button.

AndyScherzinger avatar May 25 '21 18:05 AndyScherzinger

I can also confirm Spielmops findings. The auto upload begins with-in a few seconds of activation with the default settings being used.

RJ-Make avatar Jul 07 '21 09:07 RJ-Make

Is this still a thing?

I just confirmed again yhat until the Save button is pressed, no uploading starts. Toggling things on to modify the various settings does not trigger an upload.

Of course if the cloud icon is solid before you enter settings, that means the profile is already active. It's basically equivalent to clicking save. So make sure it's still off (which it will be by default) or toggle it off (if it's on for whatever reason already).

joshtrichards avatar Jul 02 '24 20:07 joshtrichards

Of course if the cloud icon is solid before you enter settings, that means the profile is already active. It's basically equivalent to clicking save. So make sure it's still off (which it will be by default) or toggle it off

If the cloud is not solid, I can not change anything ...

Spielmops avatar Sep 11 '24 08:09 Spielmops

Is this still a thing?

Unfortunately it is!

I just confirmed again yhat until the Save button is pressed, no uploading starts. Toggling things on to modify the various settings does not trigger an upload.

BUT: Changing the settings (save -> reopen menu and adjust) the already made upload list is not possible to reset nor resetted automatically. So it keeps on uploading.

My case: new phone- > installed app -> activated auto-upload (~1800 files -- btw. works like a charm since a few years on my side; my desktop client lately uploaded even with more files (~4000) without issues!) -> then:

  1. changed settings to make datefolders
  2. list was already made and uploading to the main folder
  3. I used the "X" in the upload queue to stop the upload(doubled space)
  4. files are not synced afterwards even restarting the app/phone.

So I guess the files in list are marked not to be uploaded somewhere withing the auto-upload construct. By hitting the "X" in the upload queue?

To prevent that, I suggest to implement a stop of upload and reset of active (?) upload(ed?) list, hitting the save button. Maybe a rescan for new files is needed, too?

A good choice might be, to let users decide whether the new configuration applies to only new files or also old ones? To prevent re-uploading masses and double space.

This issue was there for long and could be fixed manually by waiting for the upload to finish and only copy new files to folders you would like them to have, delete the uneeded. But this is quite time consuming and might even double the needed space on the server and its clients (-> desktops start to sync). That might even cause more problems on other sides.

Hope I can at least put this issue to a good direction. Thanks to the programmers doing such a great work here!

lagerimsi-ds avatar Jun 11 '25 09:06 lagerimsi-ds

Is this still a thing?

Yes it is!

I am bitten by the issue described here: https://github.com/nextcloud/android/issues/8418#issuecomment-2961937995

After the recent bug resetting auto upload settings I made the mistake to activate the auto upload before changing the remote folder. So in the uploads sub menu I had uploads to both destinations in the queue. I could cancel all pending uploads but now it doesn't upload anything. Also deactivating and activating the auto uploads setting again does not help.

I am not sure if I can interact with single items in the upload view because the view is very laggy and sometimes the app hangs completely. Also the folder to upload contains almost 6000 files, so there must be around 12000 items in this view.

So is there a way to retrigger the auto upload without also starting the one to the old remote folder?

kleinph avatar Jun 12 '25 05:06 kleinph