android icon indicating copy to clipboard operation
android copied to clipboard

Add "shoot and upload a video right away"

Open kimminji00 opened this issue 5 years ago • 5 comments

Is your feature request related to a problem? Please describe.

When i click "+" button, i can upload files. But, When I click "Upload from camera", I can only take pictures and I can't shoot videos. So, I can't shoot and upload a video right away. This causes a lot of inconvenience.

Describe the solution you'd like

I think it would be nice if I could shoot and upload the video right away.

kimminji00 avatar Nov 18 '20 12:11 kimminji00

Code in question is here: https://github.com/nextcloud/android/blob/3b3c5baaacd9177be4f854844a8823ef8aa29c3a/app/src/main/java/com/owncloud/android/ui/helpers/FileOperationsHelper.java#L1082

Due to the way Intents work in Android, only Photo or Video mode is available when invoked by us unless we jump through extra hoops.

It looks like the easiest way would be to either:

  • add a second menu option and function like "Upload from Video Camera" (easiest/most straightforward and probably just fine)
  • add a chooser that comes up after someone clicks "Upload from Camera" to choose either Image or Video mode (something like this or this)

I personally prefer the first approach.

joshtrichards avatar Oct 10 '23 13:10 joshtrichards

Is this issue resolved ? I want to work on this issue.

prajyot004 avatar Nov 25 '23 07:11 prajyot004

You're welcome to do so, @prajyot004. Thanks!

joshtrichards avatar Nov 25 '23 14:11 joshtrichards

Hey @prajyot004 are you still working on this? Otherwise I'd like to try and open a pull request.

timedin-de avatar May 09 '24 13:05 timedin-de

@joshtrichards @kimminji00 I guess this issue can be closed, as the pull request got merged.

timedin-de avatar Jun 22 '24 20:06 timedin-de

@joshtrichards please close this issue, it might waste time for other developers to read and then find out that this issue was already sorted.

Yogeshjindal avatar Sep 30 '24 17:09 Yogeshjindal

Fixed in #12995

joshtrichards avatar Sep 30 '24 17:09 joshtrichards