android icon indicating copy to clipboard operation
android copied to clipboard

upload duplicated file does not open conflict dialog

Open tobiasKaminsky opened this issue 4 years ago • 56 comments

Steps to reproduce

  1. have xy in NC
  2. upload xy again
  3. see message about conflict in notification
  4. click on it -> does not open direct conflict dialog

Expected behaviour

  • click on notification should directly open up conflict dialog

Actual behaviour

  • opens upload dialog

@AndyScherzinger @jancborchardt correct, or?

tobiasKaminsky avatar May 08 '20 12:05 tobiasKaminsky

Yep, the conflict dialog should be opened immediately, before any upload is taking place. :)

jancborchardt avatar May 08 '20 23:05 jancborchardt

yes, it should

AndyScherzinger avatar May 11 '20 07:05 AndyScherzinger

This is not as easy as I hoped, as uploader is done in background. Name collision check is also done only when uploading the file.

Imagine you upload 10 files, and the 10th has a conflict, then it would pop up while you are maybe already at an entire different place in the app.

Checking it immediately is also not a reliable way, imagine you upload again 10 large files

  • check for name collision
  • everything ok
  • upload 1…9 files is ok
  • meanwhile the same file gets uploaded
  • 10th files fails

We then need to have both. Which takes some time to implement.

tobiasKaminsky avatar May 12 '20 10:05 tobiasKaminsky

Or do you have better ideas? :-)

tobiasKaminsky avatar May 12 '20 10:05 tobiasKaminsky

I have a similar error (from Infomaniak kDrive Android app), see the screenshots below:

  • "File upload conflict" as a notification
  • And when I click on it, "Error creating conflict dialog!" in the app, and nothing happens visually

Screenshot_20200726-132120 Screenshot_20200726-132132

Later, the notification comes back every time as if nothing happened.

leodavesne avatar Jul 26 '20 11:07 leodavesne

I'm also facing the same issue, I'm on app version 3.13.0

Please let me know if I can do something to help (not a android developer tho..)

Paul-dH avatar Sep 11 '20 07:09 Paul-dH

I've been having this issue for a while too

marcoambrosini avatar Nov 09 '20 12:11 marcoambrosini

Tested and works on master, so it will be in 3.14 RC2

tobiasKaminsky avatar Nov 10 '20 12:11 tobiasKaminsky

I have 3.14.0 and still have this issue

Lipown avatar Nov 29 '20 14:11 Lipown

Same, this is still an issue for me.

I have constant issues with video files being marked as conflicts by the app, I assume it's due to their size somehow messing up the upload process. It's frankly infuriating, as the only way to deal with it is to manually open the app, find the uploads tab and tap the X by each file. Far from hands off automatic upload.

Also, no conflict dialog and an error as above.

magikmw avatar Nov 30 '20 13:11 magikmw

I have 3.14.1 and also the bug

malodev avatar Dec 25 '20 21:12 malodev

What is this can u give me a the reason of this site

On Sat, Dec 26, 2020 at 1:03 AM malo [email protected] wrote:

I have 3.14.1 and also the bug

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nextcloud/android/issues/6027#issuecomment-751290665, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHRCGRZFTCWIJEJ4VX3Z4DSWT423ANCNFSM4M4EIDIA .

--

Thank You & Regards*,*

Meca Salas |

sakura120 avatar Dec 26 '20 18:12 sakura120

I am still having this issue with app version 3.15.1 on Android 10. The Nextcloud server version is 20.0.8 (stable branch, still waiting for Nextcloud 21 to be offered)

jandr avatar Apr 04 '21 16:04 jandr

Please reopen, I too have this error in app v. 3.15.1 and server 20.0.9

BenoitSvB avatar Apr 29 '21 16:04 BenoitSvB

Same for me with app v.3.15.1 and server v.21.0.1

binerf avatar May 05 '21 14:05 binerf

Same issue, app version 3.16.1

cnmicha avatar Jun 10 '21 22:06 cnmicha

I use the auto upload feature to upload my Signal backups, and I'm experiencing this issue as well. App 3.16.1, server 21.0.2. Here's the logcat: https://gist.github.com/escarlson/fa20201d4aa8e463d8551ff26b00b5d5

escarlson avatar Jun 23 '21 23:06 escarlson

App 3.17.1 Server 22.2.0 I'm having this problem several times a day. Any updates?

nateandhisjunk avatar Oct 26 '21 00:10 nateandhisjunk

Same issue in V_3.18.0 APP and V_22.2.3 Server. image image image

Passaita avatar Dec 12 '21 15:12 Passaita

Tested and works on master, so it will be in 3.14 RC2

@tobiasKaminsky please re-open this issue, as this is not fixed as of 3.18.1.

alexfornuto avatar Jan 13 '22 21:01 alexfornuto

Can confirm it is still an issue as of 3.18.1

rahulkadukar avatar Jan 18 '22 13:01 rahulkadukar

I confirm "cannot open conflict dialogue" issue with latest android nextcloud app on android 11 and nextcloud server hosted on centos 8

as i notice it seems to happen with mp4 files only

ant0nwax avatar Feb 02 '22 18:02 ant0nwax

I Confirm it is still an issue in 3.19 RC2 Beta, you maybe could write to me if you like me to test something, but i am very new to nextcloud, i run my own server and i am syncing the photos of my phone at the moment only, maybe good test case

ant0nwax avatar Feb 03 '22 13:02 ant0nwax

There's a debug APK in https://github.com/nextcloud/android/pull/9822#issuecomment-1036400647. If any of the affected users can test that, reproduce the error, and provide the logs, that would be immensely helpful to see where the error is coming from.

AlvaroBrey avatar Feb 11 '22 16:02 AlvaroBrey

There's a debug APK in #9822 (comment). If any of the affected users can test that, reproduce the error, and provide the logs, that would be immensely helpful to see where the error is coming from.

Do you want us to use this app to log in to the actual server, then re-setup synchronization to record logs? Are two apps a good practice? Or we need to uninstall the original app? Please advise.

Passaita avatar Feb 11 '22 18:02 Passaita

Hello @AlvaroBrey

i get the same error in case of mp4 Files generated by Samsung Note10 Mobile phone Error creating conflict dialogue Where to find Nextcloud QA logs?

EDIT:

I agree to @Passaita better to have only Nextcloud QA (DEV) installed, it will be too chaotic so I removed the Nextcloud QA again

Further findings with the QA version:

  • If App is running in background, the error 'Error creating conflict dialogue' still happens with mp4 files
  • If App is freshly openend and then a notification with mp4 is touched, the file dialogue opens correctly

Note: The fact that the conflicts have one notification by file is a to be improved: If there are 100 conflicts, you would like to press the user 100 times and open the conflict dialogue 100 times? Please try to integrate a counting method for the conflict dialogues and sharing ONE notification that there have been 100 conflicts and present them in a batch to the user. It would be really great for UI design and UX experience

ant0nwax avatar Feb 12 '22 04:02 ant0nwax

There's a debug APK in #9822 (comment). If any of the affected users can test that, reproduce the error, and provide the logs, that would be immensely helpful to see where the error is coming from.

Do you want us to use this app to log in to the actual server, then re-setup synchronization to record logs? Are two apps a good practice? Or we need to uninstall the original app? Please advise.

The QA APK can be installed alongside the normal app, no problem.

Where to find Nextcloud QA logs?

https://github.com/nextcloud/android/blob/master/README.md#getting-debug-info-via-logcat-mag

AlvaroBrey avatar Feb 15 '22 16:02 AlvaroBrey

This bug report did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

github-actions[bot] avatar Mar 31 '22 14:03 github-actions[bot]

Unfortunately I can't test this because Nextcloud won't play nice with my reverse proxy, so I have other problems to resolve before I can even get to this problem. Hopefully someone else gives it a whirl.

alexfornuto avatar Mar 31 '22 22:03 alexfornuto

I'm unable to download the app. Screenshot_2022-03-31-20-08-32-10_40deb401b9ffe8e1df2f1cc5ba480b12

Passaita avatar Apr 01 '22 02:04 Passaita