android icon indicating copy to clipboard operation
android copied to clipboard

Activity or context shall not be passed to the CloudClient constructor

Open Duna opened this issue 6 years ago • 1 comments
trafficstars

  1. OwnCloudClientFactory.createOwnCloudClient takes Activity as second parameter. This could be a problem of having memory leaks. e.g. OkHttp lib is pure java and does not have any link to the android app context. Could you do the same?

  2. I am wondering how did you do the Unit Tests? It is harder to test having links to Android components. It would be simple having pure java unit tests.

Duna avatar May 08 '19 08:05 Duna