nextcloud
Upload list action icon for failed/pending uploads
Follow-up to https://github.com/nextcloud/android/pull/3472
After looking at it again I had the initial confusion of "But how do I retry a failed upload?" since only the delete action is so present.
We should instead have a 3-dot icon which includes both "Retry" and "Cancel" (and cancel using the x icon, not delete as it does not delete a file).
GitMate.io thinks possibly related issues are https://github.com/nextcloud/android/issues/3105 (Notification 'Upload failed'), https://github.com/nextcloud/android/issues/581 (Uploading a picture twice fails), https://github.com/nextcloud/android/issues/2516 (More icon in upload view has wrong color), https://github.com/nextcloud/android/issues/1724 (unable to re-initiate failed uploads), and https://github.com/nextcloud/android/issues/847 (Upload view: clicking on an pending/uploaded item should do something).
Well, the delete action (trashbin) is actually also just a cancel so. Shouldn't that also be the x-icon? As for the menu, we can add a menu while Android menus don't have icons.
As for the menu, we can add a menu while Android menus don't have icons.
Right, that’s fine. :)
Well, the delete action (trashbin) is actually also just a cancel so. Shouldn't that also be the x-icon?
What do you mean by that? Deleting a file? That’s not just removing an entry/notification, but an actual file. :)
Not in the upload list... The it "deletes" the entry afaik. Cc @tobiasKaminsky
I think we are talking about the same thing then and agree. :) What I mean is that in the above screenshot, the icon which is a trashbin should instead be an X. Because it only removes an entry in this upload list but does not delete an actual file.
Btw the clear all failed option is in the toolbar's menu atm which we would then remove (only menu entry atm). This can be tested in the current dev build.
