android icon indicating copy to clipboard operation
android copied to clipboard

[TOP] Enhance sync folders

Open tobiasKaminsky opened this issue 9 years ago • 167 comments

As discussed on conf this is a collaboration between @AndyScherzinger and me. Purpose:

  • [x] Increment 1 - instant upload - #358 - release 1.4.0 :heavy_check_mark:

    • replace current instant upload
    • full support for Android 6,7
  • [x] Increment 2 - enhancement auto upload - #797 - release 2.0.0 :heavy_check_mark:

    • support video folders
    • allow any kind of folder pair (custom folders)
    • show jobs in upload pane
      • track jobs
      • get job result to update upload pane
      • if job fails: allow user to restart
    • automatic retry
    • upload updated files
  • [x] Increment 3 - upload existing files :heavy_check_mark:

    • add "upload/sync all existing images/videos/files" as an option to the auto upload folder three-dot menu.
  • [x] Increment 4 - folder upload :heavy_check_mark:

    • allow folder hierarchies
    • smart UI to semi-automatically detect and notify about potential new media folders the user can add/active for instant upload #2406
  • [x] Increment 5 - sync one way

    • sync - one way
    • free up space
  • [ ] Increment 6 - sync two way

    • sync - two way
    • ref https://github.com/nextcloud/android/issues/19

tobiasKaminsky avatar Sep 21 '16 17:09 tobiasKaminsky

Does this include a constant sync of a todo.txt file on change locally and periodically checked on server?

aparcar avatar Sep 23 '16 16:09 aparcar

@aparcar currently this will only replace instant upload. But this approach is designed to also handle a real two way sync and a constant sync of files.

tobiasKaminsky avatar Sep 25 '16 08:09 tobiasKaminsky

This issue/implementation is to be considered the top prio since we now already have > 1,300 Android 7 installations according to the play store :exclamation:

AndyScherzinger avatar Oct 05 '16 09:10 AndyScherzinger

Camera should be top of the list as this is the most wanted "folder", I guess. At least I was searching a while where it is ;-)

tobiasKaminsky avatar Oct 21 '16 19:10 tobiasKaminsky

Uhh, and caching is not working properly, right?

tobiasKaminsky avatar Oct 21 '16 19:10 tobiasKaminsky

I know it is kind of reduntant, but I think that it should be possible to enable/disable sync also in the setting of a folder (and not only in the folder sync view). [folder sync looks fantastic! :+1: :tada: ]

tobiasKaminsky avatar Oct 21 '16 19:10 tobiasKaminsky

Yeah, we can put camera on top, need to think how to put this into the comparator. Doable :) As for the caching, don't know actually. The queries need to be tweaked also since they need to order by date.

AndyScherzinger avatar Oct 21 '16 19:10 AndyScherzinger

And yes, the enable/disable can also be put into the settings. UI is close to feature complete. Then I will publish some screenshots for the discussion with the designers.

AndyScherzinger avatar Oct 21 '16 20:10 AndyScherzinger

Camera folder at the top (of the inactive): DONE

AndyScherzinger avatar Oct 24 '16 09:10 AndyScherzinger

Let's move v1 discussions to the newly created PR #358

AndyScherzinger avatar Oct 26 '16 12:10 AndyScherzinger

V1.1:

  • show jobs in upload pane
    • track jobs
    • get job result to update upload pane
    • if job fails: allow user to restart

tobiasKaminsky avatar Oct 26 '16 16:10 tobiasKaminsky

Do version numbers and milestones need to be adjusted here?

jasonbayton avatar Feb 09 '17 21:02 jasonbayton

Yes, removed since this is a long term roadmap

AndyScherzinger avatar Feb 09 '17 21:02 AndyScherzinger

Is there any ETA for this?

rugk avatar Mar 18 '17 13:03 rugk

Auto upload is also not working for me on Google Pixel XL with Android 7. Release version of Android app on Play Store.

ShaunCurrier avatar Mar 19 '17 16:03 ShaunCurrier

@shauncurrier please create a new issue. Ensure you add the troubleshooting steps you've taken also and for how long files have been waiting to upload (or if they don't make it to upload at all).

jasonbayton avatar Mar 19 '17 17:03 jasonbayton

My mistake! I was in a hurry and thought I was posting in a forum thread I had open in another tab. I'll take it elsewhere, apologies.

ShaunCurrier avatar Mar 19 '17 18:03 ShaunCurrier

At what increment are we now at? Shouldn't we have a separate bug for each of them?

madorian avatar Apr 27 '17 14:04 madorian

@madorian I just updated the top description and we are actually implementing what I described in Increment 2 now - #797. We try to keep the discussion here in general but it would make sense to still create separate issues for the different functions but keep this one as an umbrella issue referencing the detail issues and to reflect the complete road map of this feature in one place.

AndyScherzinger avatar Apr 27 '17 14:04 AndyScherzinger

Hi, Any idea when the "upload existing files" feature might become user testable ? Tormen

Tormen avatar Jun 29 '17 22:06 Tormen

Yes, and also slowly start including android 8 support 😃

Bullnados avatar Jun 30 '17 05:06 Bullnados

First off, thanks a lot for your great work on this app, it's awesome. On which increment are we standing now?

W-Hamra avatar Aug 10 '17 09:08 W-Hamra

Increment 2 has been implemented and will ship with the next stable release

AndyScherzinger avatar Aug 10 '17 09:08 AndyScherzinger

Well, we also have:

show jobs in upload pane track jobs get job result to update upload pane if job fails: allow user to restart

  • automatic retry
  • upload updated files ;)

mario avatar Aug 10 '17 10:08 mario

Do note that this roadmap/issue will be changed once @tobiasKaminsky gets the time to put notebook notes in the issues :) cc @AndyScherzinger

mario avatar Sep 14 '17 08:09 mario

Does the work on increment 3 has started ?

Orybon avatar Oct 31 '17 09:10 Orybon

@Orybon not yet. Priority is bugfixing 2.0 and e2e encryption.

AndyScherzinger avatar Oct 31 '17 11:10 AndyScherzinger

Thank you for your answer @AndyScherzinger

Orybon avatar Oct 31 '17 12:10 Orybon

About increment 3, autoupload existing : is there a workaround to force upload of the existing ? maybe moving out / in via an android file manager ?

rgarrigue avatar Jan 03 '18 13:01 rgarrigue

Yes, that will work.

On Wed, Jan 3, 2018 at 2:44 PM, Rémy G. [email protected] wrote:

About increment 3, autoupload existing : is there a workaround to force upload of the existing ? maybe moving out / in via an android file manager ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nextcloud/android/issues/285#issuecomment-355014915, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAWsvuGVv9GX_fBSERTpZeaiO4Tlufxks5tG4RUgaJpZM4KDF9B .

mario avatar Jan 03 '18 14:01 mario