android icon indicating copy to clipboard operation
android copied to clipboard

Improve Storage Permission Handling

Open alperozturk96 opened this issue 11 months ago • 2 comments

  • [x] Tests written, or not not needed

  • Simplify the StoragePermissionDialog logic by removing the external listener. The dialog’s sole responsibility should be to either open the app settings to request “Manage All Files” permission or request read-only media access. Decoupling this functionality from external listeners improves code readability and reduces complexity

  • Use precise and descriptive function names to improve code clarity and maintainability

  • Remove redundant checks in the requestStoragePermissionIfNeeded() function. This function already internally verifies whether storage permission is required, making additional checks unnecessary

  • Remove the readOnly parameter as its logic is implicitly tied to Android 11 and above (API level 30+). The current implementation redundantly checks the same condition (readOnly && Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) multiple times, which is unnecessary and can lead to confusion

  • Add READ_MEDIA_VISUAL_USER_SELECTED permission (Documentation)

Android 7 GPlayImage 1 Android 11 GenericImage 2 Android 11 GPlayImage 3 Android 15 GenericImage 4 Android 15 GPlayImage 5

alperozturk96 avatar Dec 23 '24 10:12 alperozturk96