android
android copied to clipboard
Improve Storage Permission Handling
-
[x] Tests written, or not not needed
-
Simplify the StoragePermissionDialog logic by removing the external listener. The dialog’s sole responsibility should be to either open the app settings to request “Manage All Files” permission or request read-only media access. Decoupling this functionality from external listeners improves code readability and reduces complexity
-
Use precise and descriptive function names to improve code clarity and maintainability
-
Remove redundant checks in the requestStoragePermissionIfNeeded() function. This function already internally verifies whether storage permission is required, making additional checks unnecessary
-
Remove the readOnly parameter as its logic is implicitly tied to Android 11 and above (API level 30+). The current implementation redundantly checks the same condition (readOnly && Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) multiple times, which is unnecessary and can lead to confusion
-
Add READ_MEDIA_VISUAL_USER_SELECTED permission (Documentation)
| Android 7 GPlay |
Android 11 Generic |
Android 11 GPlay |
Android 15 Generic |
Android 15 GPlay |