android
android copied to clipboard
Convert Alert Dialogs to M3
- [x] Tests written, or not not needed
Before:
After:
@alperozturk96 seems to be lacking theme in some cases via
viewThemeUtils.platform.colorTextButtons(alertDialog.getButton(AlertDialog.BUTTON_POSITIVE)); viewThemeUtils.dialog.colorMaterialAlertDialogBackground(getApplicationContext(), builder);
Some styles from XML were not applied correctly. I used M3 for those and added screenshots.
Codacy
Lint
| Type | master | PR |
| Warnings | 63 | 63 |
| Errors | 3 | 3 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 64 | 64 |
| Correctness | 65 | 65 |
| Dodgy code | 315 | 314 |
| Experimental | 1 | 1 |
| Internationalization | 7 | 7 |
| Multithreaded correctness | 6 | 6 |
| Performance | 53 | 53 |
| Security | 18 | 18 |
| Total | 529 | 528 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13195.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13195-Screenshot-blue-Light-08-12