android icon indicating copy to clipboard operation
android copied to clipboard

Convert Alert Dialogs to M3

Open alperozturk96 opened this issue 1 year ago • 2 comments

  • [x] Tests written, or not not needed

Before:

Screenshot 2024-06-27 at 14 39 37

After:

Screenshot 2024-06-27 at 14 38 48

alperozturk96 avatar Jun 27 '24 12:06 alperozturk96

@alperozturk96 seems to be lacking theme in some cases via

viewThemeUtils.platform.colorTextButtons(alertDialog.getButton(AlertDialog.BUTTON_POSITIVE));
viewThemeUtils.dialog.colorMaterialAlertDialogBackground(getApplicationContext(), builder);

Some styles from XML were not applied correctly. I used M3 for those and added screenshots.

alperozturk96 avatar Jul 01 '24 14:07 alperozturk96

Codacy

Lint

TypemasterPR
Warnings6363
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6565
Dodgy code315314
Experimental11
Internationalization77
Multithreaded correctness66
Performance5353
Security1818
Total529528

github-actions[bot] avatar Jul 01 '24 15:07 github-actions[bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13195.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar Jul 01 '24 15:07 github-actions[bot]

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13195-Screenshot-blue-Light-08-12

github-actions[bot] avatar Jul 02 '24 08:07 github-actions[bot]