android icon indicating copy to clipboard operation
android copied to clipboard

scroll bar covers the ... menu

Open rexxmagnus opened this issue 1 year ago • 8 comments

⚠️ Before posting ⚠️

  • [X] This is a bug, not a question or an enhancement.
  • [X] I've searched for similar issues and didn't find a duplicate.
  • [X] I've written a clear and descriptive title for this issue, not just "Bug" or "Crash".
  • [X] I agree to follow Nextcloud's Code of Conduct.

Steps to reproduce

Scroll in file selector so the index letter popout appears. Try to click "..." Button next to a file

Expected behaviour

Should be able to open menu

Actual behaviour

The button is not touchable

Android version

10

Device brand and model

Blackview bv900

Stock or custom OS?

Stock

Nextcloud android app version

3.29.0

Nextcloud server version

29.0.0

Using a reverse proxy?

No

Android logs

No response

Server error logs

No response

Additional information

No response

rexxmagnus avatar Jun 15 '24 11:06 rexxmagnus

Pretty subtle, but true. Not sure this is a bug though. The nearest file entry's file menu is covered by the extra index letter scroll bar for ~1 second. Then everything goes back to normal. : 🤔

joshtrichards avatar Jun 15 '24 16:06 joshtrichards

Yes, it does go away, but this only works for files that are not the first in the list. If it's the first file in the list you want to click, touching the "..." zone actually brings up the letter and scrolling functionality. I suspect this would also happen with the last item, since the scrollbar is always going to be next to the last or first in the list.

rexxmagnus avatar Jun 15 '24 21:06 rexxmagnus

I guess this is the bug:

https://github.com/nextcloud/android/assets/67455295/9ed4ad44-58ea-45f5-8cf6-37d1a9f3c2a8

alperozturk96 avatar Jun 19 '24 08:06 alperozturk96

Old New
old new

While trying to fix this issue, I adjusted the margins and zIndex. The result was a new look, which I found more appealing and issue also solved.

@nextcloud/designers What do you think? @jancborchardt @joshtrichards

alperozturk96 avatar Jun 19 '24 09:06 alperozturk96

@alperozturk96 nice on trying it out, but it diesn't look quite native, and a bit overly complex. We should rather go with native Android lists so people feel at home. :)

jancborchardt avatar Jun 19 '24 10:06 jancborchardt

@jancborchardt Unintentionally, something like this emerged. We can play with the values and make it better.

I will try to fix it without changing appearance, of course, just wanted to share. Anyway thanks for the feedback. :)

alperozturk96 avatar Jun 19 '24 10:06 alperozturk96

This 3rd party library used for this feature. When the side scroll bar appears, the onClick event is not triggered immediately. Users must wait for the auto-hide animation (1.5 second) to complete. Unfortunately, due to library limitations, we cannot fix this without disrupting the UI. Adding extra padding for the trailing icons is an option, but it would make the file list look odd.

Changing zIndex didn't work Using bringFront() function didn't work Using FixOnItemTouchListenerRecyclerView didn't work as well

alperozturk96 avatar Jun 19 '24 12:06 alperozturk96

@alperozturk96 @tobiasKaminsky is there no native scroll bar library for this? Or would it be so bad if we just use the native scroll bar here without that extra functionality, if it interferes with more basic things like the actions?

jancborchardt avatar Aug 27 '24 09:08 jancborchardt