android icon indicating copy to clipboard operation
android copied to clipboard

Refactor Encrypted Upload

Open alperozturk96 opened this issue 1 year ago • 2 comments

  • [x] Tests written, or not not needed

Improvements

The function encryptedUpload was quite large and challenging to read and debug. Therefore, in this pull request, it has been divided into multiple smaller functions for better readability and easier debugging.

E2E Region Added

Screenshot 2024-04-26 at 08 18 30

Known Issues on Master and this PR:

How to Test

  1. Create encrypted folder
  2. Upload file to the encrypted folder
  3. Upload multiple files to the encrypted folder
  4. Create sub folder and upload some files to the subfolder

Do this test for latest Nextcloud version and v27.1.7

alperozturk96 avatar Apr 25 '24 12:04 alperozturk96

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12934.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar May 02 '24 07:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 223 lines in your changes are missing coverage. Please review.

Project coverage is 26.90%. Comparing base (6c8c58f) to head (82af5b4). Report is 33 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12934      +/-   ##
============================================
- Coverage     26.97%   26.90%   -0.08%     
- Complexity     3284     3309      +25     
============================================
  Files           632      636       +4     
  Lines         46629    47019     +390     
  Branches       6150     6219      +69     
============================================
+ Hits          12577    12649      +72     
- Misses        32219    32530     +311     
- Partials       1833     1840       +7     
Files Coverage Δ
...m/owncloud/android/operations/e2e/E2EClientData.kt 0.00% <0.00%> (ø)
...ava/com/owncloud/android/operations/e2e/E2EData.kt 0.00% <0.00%> (ø)
...va/com/owncloud/android/operations/e2e/E2EFiles.kt 0.00% <0.00%> (ø)
...ncloud/android/operations/UploadFileOperation.java 39.80% <0.00%> (-3.10%) :arrow_down:

... and 28 files with indirect coverage changes

codecov[bot] avatar May 02 '24 14:05 codecov[bot]

Codacy

Lint

TypemasterPR
Warnings7272
Errors33

SpotBugs

CategoryBaseNew
Bad practice6666
Correctness7373
Dodgy code349349
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total580580

github-actions[bot] avatar May 02 '24 14:05 github-actions[bot]