Login Flow v2

[alperozturk96]

• [x] Tests written, or not not needed

Improvements

Login Flow v2 used instead of v1. Documentation

Instead of using WebView default web browser used for login.

How to Test

Open app tap login button default web browser must appear, enter user info go back to app manually, app should try to login automatically

Try to login via Scanning QR Code

Note

If user didn't complete login flow inside default web browser and get back to app, app will redirect to default web browser again

Edge cases

Can we redirect automatically back to the app after login from web browser? --> Answer

If we add deeplink to the "/login/v2/grant" this endpoint we may trigger to get back to app automatically.

Demo

https://github.com/nextcloud/android/assets/67455295/6e9da91f-90e9-4739-b894-1ad2595efdd3

[github-actions[bot]]

Codacy

Lint

Type	master	PR
Warnings	71	71
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	67	67
Correctness	72	72
Dodgy code	345	345
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	6	6
Performance	57	57
Security	19	19
Total	576	576

[github-actions[bot]]

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12922-Screenshot-blue-Light-10-43

[github-actions[bot]]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12922.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.