android icon indicating copy to clipboard operation
android copied to clipboard

Improve retry failed uploads function

Open JonasMayerDev opened this issue 1 year ago • 3 comments
trafficstars

Simple optimization to the retry Uploads function. The main improvement is to not restart the worker for every upload, but just update the database and in the end restart the upload worker for each account once.

Should solve some inconsistencies in the upload tab when handling a lot of files (around 7000).

  • [X] Tests written, or not not needed

JonasMayerDev avatar Apr 22 '24 15:04 JonasMayerDev

Codacy

Lint

TypemasterPR
Warnings7171
Errors33

SpotBugs

CategoryBaseNew
Bad practice6767
Correctness7272
Dodgy code341341
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total572572

github-actions[bot] avatar Apr 30 '24 14:04 github-actions[bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12911.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar Apr 30 '24 14:04 github-actions[bot]