android
android copied to clipboard
Improve retry failed uploads function
trafficstars
Simple optimization to the retry Uploads function. The main improvement is to not restart the worker for every upload, but just update the database and in the end restart the upload worker for each account once.
Should solve some inconsistencies in the upload tab when handling a lot of files (around 7000).
- [X] Tests written, or not not needed
Codacy
Lint
| Type | master | PR |
| Warnings | 71 | 71 |
| Errors | 3 | 3 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 67 | 67 |
| Correctness | 72 | 72 |
| Dodgy code | 341 | 341 |
| Experimental | 1 | 1 |
| Internationalization | 7 | 7 |
| Malicious code vulnerability | 2 | 2 |
| Multithreaded correctness | 6 | 6 |
| Performance | 57 | 57 |
| Security | 19 | 19 |
| Total | 572 | 572 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12911.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.