android
android copied to clipboard
Unify Notifications
- [x] Tests written, or not not needed
Before
https://github.com/nextcloud/android/assets/67455295/80e673c5-8e9c-4136-9b52-07a3ce403637
After
https://github.com/nextcloud/android/assets/67455295/608b918a-2f1b-48ca-bc71-55a7fe7e6fc3
Improvements
-
All notifications are dismissible. Some users are experiencing problems with notifications that are stuck.
-
One notification can be used for downloads and uploads. Instead of showing progress with one by one now we can show all progress with one notification.
Example
1 / 10 abc.rtf … 2 / 10 abc2.docx… ... ... 10 / 10 abc3.pdf…
How to Test
-
Test one file download
-
Test one file upload
-
Test multiple file upload
-
Test multiple file download
-
Test all above scenarios for e2e
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12907.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
Codacy
Lint
| Type | master | PR |
| Warnings | 72 | 72 |
| Errors | 3 | 3 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 66 | 66 |
| Correctness | 73 | 73 |
| Dodgy code | 349 | 349 |
| Experimental | 1 | 1 |
| Internationalization | 7 | 7 |
| Malicious code vulnerability | 2 | 2 |
| Multithreaded correctness | 6 | 6 |
| Performance | 57 | 57 |
| Security | 19 | 19 |
| Total | 580 | 580 |
Codacy
Lint
| Type | master | PR |
| Warnings | 70 | 70 |
| Errors | 3 | 3 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 64 | 64 |
| Correctness | 69 | 69 |
| Dodgy code | 346 | 346 |
| Experimental | 1 | 1 |
| Internationalization | 7 | 7 |
| Malicious code vulnerability | 2 | 2 |
| Multithreaded correctness | 6 | 6 |
| Performance | 57 | 57 |
| Security | 19 | 19 |
| Total | 571 | 571 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12907.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.