android icon indicating copy to clipboard operation
android copied to clipboard

Unify Notifications

Open alperozturk96 opened this issue 1 year ago • 2 comments

  • [x] Tests written, or not not needed

Before

https://github.com/nextcloud/android/assets/67455295/80e673c5-8e9c-4136-9b52-07a3ce403637

After

https://github.com/nextcloud/android/assets/67455295/608b918a-2f1b-48ca-bc71-55a7fe7e6fc3

Improvements

  • All notifications are dismissible. Some users are experiencing problems with notifications that are stuck.

  • One notification can be used for downloads and uploads. Instead of showing progress with one by one now we can show all progress with one notification.

Example

1 / 10 abc.rtf … 2 / 10 abc2.docx… ... ... 10 / 10 abc3.pdf…

How to Test

  • Test one file download

  • Test one file upload

  • Test multiple file upload

  • Test multiple file download

  • Test all above scenarios for e2e

alperozturk96 avatar Apr 19 '24 13:04 alperozturk96

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12907.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar May 03 '24 07:05 github-actions[bot]

Codacy

Lint

TypemasterPR
Warnings7272
Errors33

SpotBugs

CategoryBaseNew
Bad practice6666
Correctness7373
Dodgy code349349
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total580580

github-actions[bot] avatar May 03 '24 07:05 github-actions[bot]

Codacy

Lint

TypemasterPR
Warnings7070
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6969
Dodgy code346346
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total571571

github-actions[bot] avatar Jun 03 '24 08:06 github-actions[bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12907.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar Jun 03 '24 08:06 github-actions[bot]