android icon indicating copy to clipboard operation
android copied to clipboard

Reload rich document edition on reload event from webview (triggered on session expiration)

Open nicofrand opened this issue 1 year ago • 4 comments

This fixes the android part of https://github.com/nextcloud/android/issues/12138. The webview part needs some tweaking but can already be used with this PR for testing: https://github.com/nicofrand/nextcloud-text/commits/fixReconnect/.

I am quite new to android development and brand new to this app (thanks @juliushaertl for all the help already). I don't know if tests should be added or how to put them. I am open to discussion ofc.

To test (see https://github.com/nextcloud/android/issues/12138):

  • Use this version of the Text app that will trigger a reload event when a 403 error is caught: https://github.com/nicofrand/nextcloud-text/commits/fixReconnect/
  • Open a markdown file in the android app
  • Put the app in background and wait a few minutes (so the session expires due to lack of sync requests sent while in background)
  • Go back to app: the app should reload
  • [ ] Tests written, or not not needed

nicofrand avatar Apr 04 '24 06:04 nicofrand

@nicofrand Maybe you can also already open a pull request for the text part for easier testing and early review :)

juliusknorr avatar Apr 12 '24 06:04 juliusknorr

@nicofrand Maybe you can also already open a pull request for the text part for easier testing and early review :)

Done: https://github.com/nextcloud/text/pull/5662 There are still things to improve though on the Text app side.

nicofrand avatar Apr 12 '24 06:04 nicofrand

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

github-actions[bot] avatar Apr 19 '24 01:04 github-actions[bot]

It's a bit ironic to get a survey about a pull request that did not receive any feedback…

nicofrand avatar Apr 19 '24 06:04 nicofrand

Anyone for a review?

nicofrand avatar May 30 '24 12:05 nicofrand

This is one of the top Nextcloud bugs for me. I encounter it multiple times a day.

dbolton avatar Jun 02 '24 21:06 dbolton

Moved to https://github.com/nextcloud/android/pull/13247, so that CI can work.

tobiasKaminsky avatar Jul 08 '24 11:07 tobiasKaminsky

Thanks for this fix, @nicofrand :clap:

tobiasKaminsky avatar Jul 08 '24 11:07 tobiasKaminsky