android icon indicating copy to clipboard operation
android copied to clipboard

Add SPDX header

Open AndyScherzinger opened this issue 1 year ago • 7 comments
trafficstars

  • [x] Tests written, or not not needed

AndyScherzinger avatar Apr 03 '24 16:04 AndyScherzinger

Hi @starypatyk @AlvaroBrey @ezaquarii sorry to bug you, but in an effort to add standardized SPDX license/copyright headers to the source files of Nextcloud Android Files I spotted some classes (not limited to the ones ion this PR I guess) that are mislabelled as GPL3+ instead of AGPL3+ as mentioned in the projects readme file. So I wanted to get your feedback if you are fine we changing it from GLP3+ to AGPL3+

Thanks in advance for a brief feedback and sorry to bother you.

AndyScherzinger avatar Apr 03 '24 16:04 AndyScherzinger

I'm ok.

ezaquarii avatar Apr 03 '24 17:04 ezaquarii

Sorry for delayed response - I have been travelling lately. Fine for me as well. :+1:

starypatyk avatar Apr 18 '24 20:04 starypatyk

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12809.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar Apr 23 '24 07:04 github-actions[bot]

Codacy

Lint

TypemasterPR
Warnings7171
Errors33

SpotBugs

CategoryBaseNew
Bad practice6767
Correctness7272
Dodgy code345345
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total576576

github-actions[bot] avatar Apr 23 '24 07:04 github-actions[bot]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

github-actions[bot] avatar Apr 23 '24 07:04 github-actions[bot]

I'm fine with this too, sorry for the late reply!

AlvaroBrey avatar Apr 23 '24 10:04 AlvaroBrey

Thanks everyone for the replies 🙏 Highly appreciated - now possible to get merged 🚀

AndyScherzinger avatar Aug 01 '24 20:08 AndyScherzinger

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12809.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar Aug 01 '24 21:08 github-actions[bot]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

github-actions[bot] avatar Aug 02 '24 01:08 github-actions[bot]