android
android copied to clipboard
Add SPDX header
- [x] Tests written, or not not needed
Hi @starypatyk @AlvaroBrey @ezaquarii sorry to bug you, but in an effort to add standardized SPDX license/copyright headers to the source files of Nextcloud Android Files I spotted some classes (not limited to the ones ion this PR I guess) that are mislabelled as GPL3+ instead of AGPL3+ as mentioned in the projects readme file. So I wanted to get your feedback if you are fine we changing it from GLP3+ to AGPL3+
Thanks in advance for a brief feedback and sorry to bother you.
I'm ok.
Sorry for delayed response - I have been travelling lately. Fine for me as well. :+1:
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12809.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
Codacy
Lint
| Type | master | PR |
| Warnings | 71 | 71 |
| Errors | 3 | 3 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 67 | 67 |
| Correctness | 72 | 72 |
| Dodgy code | 345 | 345 |
| Experimental | 1 | 1 |
| Internationalization | 7 | 7 |
| Malicious code vulnerability | 2 | 2 |
| Multithreaded correctness | 6 | 6 |
| Performance | 57 | 57 |
| Security | 19 | 19 |
| Total | 576 | 576 |
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.
I'm fine with this too, sorry for the late reply!
Thanks everyone for the replies 🙏 Highly appreciated - now possible to get merged 🚀
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12809.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.