android icon indicating copy to clipboard operation
android copied to clipboard

Published 20 hours ago • verified publisher icon nextcloud

Check Usage of previousSortGroupState

Open JonasMayerDev opened this issue 1 year ago • 1 comments 

          This would negate purpose of `previousSortGroupState`, which was introduced by #11965. If this choice was deliberate, check that *all* edge cases are handled appropriately and remove this variable entirely.

Originally posted by @ZetaTom in https://github.com/nextcloud/android/pull/12540#discussion_r1489207827

JonasMayerDev avatar Feb 14 '24 14:02 JonasMayerDev

Handling visibility of Sort List Group with "Stack<Boolean> previousSortGroupState" not ideal. It caused crashed and wrong usage of showSortListGroup function. Crash has been fixed in this PR.

Things To Do

  1. Check usage of previousSortGroupState if its not necessary remove it.
  2. Decouple Sort List Group visibility from previousSortGroupState

alperozturk96 avatar Feb 14 '24 14:02 alperozturk96