Fix ReceiveExternalFilesActivity intent

[ZetaTom]

trafficstars

This change fixes a crash when the app was presented with a specially crafted intent.

Intents to share files with Nextcloud via ReceiveExternalFilesActivity.java are now checked, if they contain the appropriate actions and extras before attempting to parse them.

If an intent lacks the appropriate action or extras, an error message is displayed.

• [ ] Tests written, or not not needed

[github-actions[bot]]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12406.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions[bot]]

Codacy

Lint

Type	master	PR
Warnings	71	71
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	68	68
Correctness	71	71
Dodgy code	351	351
Experimental	2	2
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	6	6
Performance	56	56
Security	19	19
Total	582	582

[github-actions[bot]]

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12406-Screenshot-blue-Light-07-48

[github-actions[bot]]

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!