android icon indicating copy to clipboard operation
android copied to clipboard

Fix infinite loading of folders in shared tab

Open ZetaTom opened this issue 1 year ago • 3 comments
trafficstars

This change fixes an issue where users were left with an infinite Loading... message, when attempting to open a folder from the Shared tab.

Steps to reproduce

  1. open Nextcloud Android client
  2. create empty folder in root directory
  3. share said folder with another user on the same instance
  4. open Shared tab
  5. tap on the new folder

Previously the Loading... message would be displayed without any further feedback.

Supersedes #11401


  • [ ] Tests written, or not not needed

ZetaTom avatar Dec 12 '23 09:12 ZetaTom

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12276.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar Mar 11 '24 15:03 github-actions[bot]

Codacy

Lint

TypemasterPR
Warnings7171
Errors33

SpotBugs

CategoryBaseNew
Bad practice6868
Correctness7171
Dodgy code351351
Experimental22
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5656
Security1919
Total582582

github-actions[bot] avatar Mar 11 '24 18:03 github-actions[bot]

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12276-Screenshot-blue-Light-18-40

github-actions[bot] avatar Mar 11 '24 18:03 github-actions[bot]

Screenshot test failure seems to be unrelated, as they highlight different fragments/activities.

ZetaTom avatar Mar 12 '24 07:03 ZetaTom

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

github-actions[bot] avatar Mar 31 '24 01:03 github-actions[bot]