android
android copied to clipboard
Correctly update file after sharing
Step to reproduce:
- Open the NextCloud app and login
- Click on share icon of any file- Image/video/audio/ office file
- Click on "Link" from its popup
- Now check the icon
Actual result: Share-Icon is remain same . When refresh the page then icon gets change as link icon
Expected result: Icon should get change after link share from its popup
- [x] Tests written, or not not needed
/backport to stable-3.25
/rebase
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11775.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
Codacy
Lint
| Type | master | PR |
| Warnings | 71 | 71 |
| Errors | 3 | 3 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 67 | 67 |
| Correctness | 68 | 68 |
| Dodgy code | 350 | 350 |
| Experimental | 1 | 1 |
| Internationalization | 7 | 7 |
| Malicious code vulnerability | 2 | 2 |
| Multithreaded correctness | 6 | 6 |
| Performance | 58 | 58 |
| Security | 19 | 19 |
| Total | 578 | 578 |
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/11775-Screenshot-blue-Light-20-27