android icon indicating copy to clipboard operation
android copied to clipboard

Upload in background

Open tobiasKaminsky opened this issue 3 years ago • 4 comments

  • [ ] Tests written, or not not needed

tobiasKaminsky avatar Sep 15 '22 13:09 tobiasKaminsky

/rebase

tobiasKaminsky avatar Oct 11 '22 06:10 tobiasKaminsky

Codecov Report

Merging #10737 (73aebc0) into master (64d8b0e) will increase coverage by 27.94%. The diff coverage is 70.08%.

:exclamation: Current head 73aebc0 differs from pull request most recent head e2ef6c4. Consider uploading reports for the commit e2ef6c4 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #10737       +/-   ##
=============================================
+ Coverage      3.29%   31.23%   +27.94%     
- Complexity      420     3281     +2861     
=============================================
  Files           539      542        +3     
  Lines         40264    40433      +169     
  Branches       5555     5568       +13     
=============================================
+ Hits           1325    12628    +11303     
+ Misses        38858    25961    -12897     
- Partials         81     1844     +1763     
Impacted Files Coverage Δ
...java/com/nextcloud/client/di/ComponentsModule.java 0.00% <ø> (ø)
.../com/nextcloud/client/jobs/BackgroundJobManager.kt 0.00% <ø> (ø)
...pp/src/main/java/com/owncloud/android/MainApp.java 54.71% <ø> (+53.80%) :arrow_up:
...d/android/operations/SynchronizeFileOperation.java 37.23% <0.00%> (+37.23%) :arrow_up:
...android/operations/SynchronizeFolderOperation.java 43.41% <ø> (+43.41%) :arrow_up:
...ncloud/android/operations/UploadFileOperation.java 58.59% <ø> (+58.59%) :arrow_up:
...ud/android/providers/DocumentsStorageProvider.java 52.70% <ø> (+52.70%) :arrow_up:
.../android/ui/activity/ConflictsResolveActivity.java 23.76% <0.00%> (+23.76%) :arrow_up:
...roid/ui/activity/ReceiveExternalFilesActivity.java 0.35% <0.00%> (+0.35%) :arrow_up:
...ncloud/android/ui/activity/UploadListActivity.java 5.21% <0.00%> (+5.21%) :arrow_up:
... and 292 more

codecov[bot] avatar Oct 11 '22 07:10 codecov[bot]

blue-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10737-Screenshot-blue-Light-07-43

github-actions[bot] avatar Oct 11 '22 07:10 github-actions[bot]

Let's see what CI says :)

tobiasKaminsky avatar Oct 12 '22 10:10 tobiasKaminsky

/rebase

tobiasKaminsky avatar Oct 12 '22 12:10 tobiasKaminsky

@AlvaroBrey spotlessKotlinCheck fails, but auto format in AS is fine with it.

tobiasKaminsky avatar Oct 13 '22 06:10 tobiasKaminsky

Rebased and fixed for m3 ✨

AlvaroBrey avatar Oct 14 '22 18:10 AlvaroBrey

@tobiasKaminsky please check my last 2 commits, for reference

AlvaroBrey avatar Oct 17 '22 15:10 AlvaroBrey

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/6299-IT-stable-15-53

nextcloud-android-bot avatar Oct 17 '22 15:10 nextcloud-android-bot

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/6299-IT-master-15-54

nextcloud-android-bot avatar Oct 17 '22 15:10 nextcloud-android-bot

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10737.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar Oct 17 '22 16:10 github-actions[bot]

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10737-Screenshot-blue-Light-16-08

github-actions[bot] avatar Oct 17 '22 16:10 github-actions[bot]

Codacy

Lint

TypemasterPR
Warnings8383
Errors00

SpotBugs

CategoryBaseNew
Bad practice2828
Correctness4646
Dodgy code341341
Internationalization99
Multithreaded correctness99
Performance5858
Security2828
Total519519

github-actions[bot] avatar Oct 17 '22 16:10 github-actions[bot]