Dashboard

[tobiasKaminsky]

Fix https://github.com/nextcloud/android/issues/10629

TODO

• [ ] if returned entry size is 14, then show "load more" button, else not

• [ ] Tests written, or not not needed

[nickvergessen]

if returned entry size is 14, then show "load more" button, else not

So should the dashboards register the button or not? If the dashboards do, you shouldn't be able to identify/distinguish it from any other button, so I think the registration condition should be checked by the app rather than the clients?

[nickvergessen]

Problem	Question
	The icons you retrieve from the server are supposed to always be black I guess. So you can invert them for dark mode? But I see user status is always returning a white icon, so I guess it is broken there in bright mode?

[nickvergessen]

More issues:

1. The widgets icon is rounded (cutting of the tick in the bottom right making Talk look like a circle)
2. The widget item icons are not rounded (avatars should be round)
3. If the widget item is a "small" it should be used in a suitable size (the icons are 16px iirc on the server)

[nickvergessen]

Okay the top bar icon is fixed by clicking the refresh button, but the avatars stay "square" and small

[codecov[bot]]

Codecov Report

Merging #10719 (183c9b3) into master (4bc0e24) will increase coverage by 27.92%. The diff coverage is 5.49%.

:exclamation: Current head 183c9b3 differs from pull request most recent head a7d8fc0. Consider uploading reports for the commit a7d8fc0 to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #10719       +/-   ##
=============================================
+ Coverage      3.29%   31.21%   +27.92%     
- Complexity      427     3292     +2865     
=============================================
  Files           539      546        +7     
  Lines         40237    40712      +475     
  Branches       5559     5614       +55     
=============================================
+ Hits           1324    12710    +11386     
+ Misses        38831    26089    -12742     
- Partials         82     1913     +1831     

Impacted Files	Coverage Δ
...java/com/nextcloud/client/di/ComponentsModule.java	0.00% <ø> (ø)
...m/nextcloud/client/preferences/AppPreferences.java	0.00% <ø> (ø)
...ent/widget/DashboardWidgetConfigurationActivity.kt	0.00% <0.00%> (ø)
...nextcloud/client/widget/DashboardWidgetProvider.kt	0.00% <0.00%> (ø)
.../nextcloud/client/widget/DashboardWidgetService.kt	0.00% <0.00%> (ø)
.../nextcloud/client/widget/DashboardWidgetUpdater.kt	0.00% <0.00%> (ø)
...com/nextcloud/client/widget/WidgetConfiguration.kt	0.00% <0.00%> (ø)
...ava/com/owncloud/android/ui/EmptyRecyclerView.java	55.55% <0.00%> (+55.55%)	:arrow_up:
...m/owncloud/android/ui/activity/DrawerActivity.java	49.33% <ø> (+49.14%)	:arrow_up:
...ud/android/ui/activity/ManageAccountsActivity.java	0.43% <ø> (ø)
... and 309 more

[tobiasKaminsky]

⚠ I rebased

[github-actions[bot]]

blue-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10719-Screenshot-blue-Light-05-24

[github-actions[bot]]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10719.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions[bot]]

Codacy

Lint

Type	master	PR
Warnings	85	85
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	28	28
Correctness	46	46
Dodgy code	355	355
Internationalization	9	9
Multithreaded correctness	9	9
Performance	58	58
Security	28	28
Total	533	533

[nextcloud-android-bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/6259-IT-master-08-53