android icon indicating copy to clipboard operation
android copied to clipboard

Disable search on folder picker activity

Open AlvaroBrey opened this issue 3 years ago • 3 comments

  • [x] Tests written, or not not needed

AlvaroBrey avatar Aug 08 '22 15:08 AlvaroBrey

Codacy

Lint

TypemasterPR
Warnings8585
Errors00

SpotBugs

CategoryBaseNew
Bad practice2929
Correctness4646
Dodgy code353353
Experimental11
Internationalization99
Multithreaded correctness99
Performance5858
Security2828
Total533533

github-actions[bot] avatar Aug 08 '22 15:08 github-actions[bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10610.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar Aug 08 '22 15:08 github-actions[bot]

Codecov Report

Merging #10610 (359d2ab) into master (556a6bb) will decrease coverage by 0.00%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #10610      +/-   ##
============================================
- Coverage     31.56%   31.56%   -0.01%     
+ Complexity     3310     3308       -2     
============================================
  Files           540      540              
  Lines         40217    40217              
  Branches       5560     5560              
============================================
- Hits          12695    12693       -2     
- Misses        25614    25628      +14     
+ Partials       1908     1896      -12     
Impacted Files Coverage Δ
...n/java/com/nextcloud/ui/SquareLoaderImageView.java 25.00% <0.00%> (-25.00%) :arrow_down:
...va/com/owncloud/android/utils/FilesSyncHelper.java 14.60% <0.00%> (-6.75%) :arrow_down:
...cloud/android/datamodel/UploadsStorageManager.java 68.59% <0.00%> (-3.62%) :arrow_down:
...loud/android/datamodel/ThumbnailsCacheManager.java 39.24% <0.00%> (-0.18%) :arrow_down:
...loud/android/datamodel/FileDataStorageManager.java 60.50% <0.00%> (+0.08%) :arrow_up:
...cloud/android/ui/activity/FileDisplayActivity.java 26.52% <0.00%> (+0.41%) :arrow_up:
...oud/android/operations/RefreshFolderOperation.java 76.86% <0.00%> (+0.71%) :arrow_up:
.../java/com/owncloud/android/utils/DisplayUtils.java 37.64% <0.00%> (+0.88%) :arrow_up:
...cloud/android/ui/activity/SyncedFoldersActivity.kt 20.18% <0.00%> (+1.13%) :arrow_up:
.../third_parties/daveKoeller/AlphanumComparator.java 88.09% <0.00%> (+1.19%) :arrow_up:

codecov[bot] avatar Aug 08 '22 16:08 codecov[bot]

/backport to stable-3.21

AlvaroBrey avatar Aug 22 '22 12:08 AlvaroBrey