android
android copied to clipboard
Disable search on folder picker activity
- [x] Tests written, or not not needed
Codacy
Lint
| Type | master | PR |
| Warnings | 85 | 85 |
| Errors | 0 | 0 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 29 | 29 |
| Correctness | 46 | 46 |
| Dodgy code | 353 | 353 |
| Experimental | 1 | 1 |
| Internationalization | 9 | 9 |
| Multithreaded correctness | 9 | 9 |
| Performance | 58 | 58 |
| Security | 28 | 28 |
| Total | 533 | 533 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10610.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
Codecov Report
Merging #10610 (359d2ab) into master (556a6bb) will decrease coverage by
0.00%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #10610 +/- ##
============================================
- Coverage 31.56% 31.56% -0.01%
+ Complexity 3310 3308 -2
============================================
Files 540 540
Lines 40217 40217
Branches 5560 5560
============================================
- Hits 12695 12693 -2
- Misses 25614 25628 +14
+ Partials 1908 1896 -12
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...n/java/com/nextcloud/ui/SquareLoaderImageView.java | 25.00% <0.00%> (-25.00%) |
:arrow_down: |
| ...va/com/owncloud/android/utils/FilesSyncHelper.java | 14.60% <0.00%> (-6.75%) |
:arrow_down: |
| ...cloud/android/datamodel/UploadsStorageManager.java | 68.59% <0.00%> (-3.62%) |
:arrow_down: |
| ...loud/android/datamodel/ThumbnailsCacheManager.java | 39.24% <0.00%> (-0.18%) |
:arrow_down: |
| ...loud/android/datamodel/FileDataStorageManager.java | 60.50% <0.00%> (+0.08%) |
:arrow_up: |
| ...cloud/android/ui/activity/FileDisplayActivity.java | 26.52% <0.00%> (+0.41%) |
:arrow_up: |
| ...oud/android/operations/RefreshFolderOperation.java | 76.86% <0.00%> (+0.71%) |
:arrow_up: |
| .../java/com/owncloud/android/utils/DisplayUtils.java | 37.64% <0.00%> (+0.88%) |
:arrow_up: |
| ...cloud/android/ui/activity/SyncedFoldersActivity.kt | 20.18% <0.00%> (+1.13%) |
:arrow_up: |
| .../third_parties/daveKoeller/AlphanumComparator.java | 88.09% <0.00%> (+1.19%) |
:arrow_up: |
/backport to stable-3.21