android icon indicating copy to clipboard operation
android copied to clipboard

BackupFragment: request write_calendar permission for backup

Open AlvaroBrey opened this issue 3 years ago • 5 comments

Needed to ensure events have UIDs for ICS export

Fixes #9527

  • [x] Tests written, or not not needed

AlvaroBrey avatar Aug 08 '22 14:08 AlvaroBrey

/backport to stable-3.21

AlvaroBrey avatar Aug 08 '22 14:08 AlvaroBrey

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10609.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar Aug 17 '22 15:08 github-actions[bot]

Codacy

Lint

TypemasterPR
Warnings8585
Errors00

SpotBugs

CategoryBaseNew
Bad practice2929
Correctness4646
Dodgy code353353
Experimental11
Internationalization99
Multithreaded correctness99
Performance5858
Security2828
Total533533

github-actions[bot] avatar Aug 17 '22 15:08 github-actions[bot]

Codecov Report

Merging #10609 (2d39820) into master (c1bda69) will decrease coverage by 0.01%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #10609      +/-   ##
============================================
- Coverage     31.73%   31.71%   -0.02%     
  Complexity     3321     3321              
============================================
  Files           540      540              
  Lines         40217    40221       +4     
  Branches       5560     5561       +1     
============================================
- Hits          12761    12755       -6     
- Misses        25546    25558      +12     
+ Partials       1910     1908       -2     
Impacted Files Coverage Δ
...oid/ui/fragment/contactsbackup/BackupFragment.java 0.00% <0.00%> (ø)
...third_parties/sufficientlysecure/SaveCalendar.java 0.00% <ø> (ø)
...d/android/operations/UpdateOCVersionOperation.java 64.28% <0.00%> (-7.15%) :arrow_down:
...ncloud/android/ui/activity/FolderPickerActivity.kt 27.24% <0.00%> (-4.31%) :arrow_down:
...d/android/operations/SynchronizeFileOperation.java 37.23% <0.00%> (-1.07%) :arrow_down:
...cloud/android/ui/activity/SyncedFoldersActivity.kt 19.50% <0.00%> (-0.69%) :arrow_down:
...xtcloud/client/account/UserAccountManagerImpl.java 71.62% <0.00%> (-0.68%) :arrow_down:
...loud/android/datamodel/FileDataStorageManager.java 60.98% <0.00%> (-0.49%) :arrow_down:
.../java/com/nextcloud/client/jobs/OfflineSyncWork.kt 60.93% <0.00%> (ø)
...cloud/android/ui/activity/FileDisplayActivity.java 27.75% <0.00%> (+0.49%) :arrow_up:
... and 4 more

codecov[bot] avatar Aug 17 '22 16:08 codecov[bot]