android
android copied to clipboard
Bump OUTDATED_SERVER_VERSION to Nextcloud 21
- [x] Tests written, or not not needed
Codecov Report
Merging #10608 (abe583d) into master (a159568) will increase coverage by
28.38%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #10608 +/- ##
=============================================
+ Coverage 3.28% 31.67% +28.38%
- Complexity 427 3324 +2897
=============================================
Files 540 540
Lines 40243 40243
Branches 5559 5559
=============================================
+ Hits 1321 12745 +11424
+ Misses 38839 25621 -13218
- Partials 83 1877 +1794
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...pp/src/main/java/com/owncloud/android/MainApp.java | 58.48% <100.00%> (+57.57%) |
:arrow_up: |
| ...roid/ui/activity/ReceiveExternalFilesActivity.java | 0.35% <0.00%> (+0.35%) |
:arrow_up: |
| ...owncloud/android/ui/activity/PassCodeActivity.java | 0.49% <0.00%> (+0.49%) |
:arrow_up: |
| ...cloud/android/ui/preview/PreviewImageActivity.java | 0.55% <0.00%> (+0.55%) |
:arrow_up: |
| ...owncloud/android/ui/activity/UserInfoActivity.java | 0.58% <0.00%> (+0.58%) |
:arrow_up: |
| ...oud/android/ui/activity/NotificationsActivity.java | 0.59% <0.00%> (+0.59%) |
:arrow_up: |
| ...ui/fragment/contactsbackup/BackupListFragment.java | 0.93% <0.00%> (+0.93%) |
:arrow_up: |
| ...wncloud/android/ui/preview/PreviewVideoActivity.kt | 0.94% <0.00%> (+0.94%) |
:arrow_up: |
| ...loud/android/ui/activities/ActivitiesActivity.java | 1.03% <0.00%> (+1.03%) |
:arrow_up: |
| ...cloud/android/ui/activity/ExternalSiteWebView.java | 1.08% <0.00%> (+1.08%) |
:arrow_up: |
| ... and 275 more |
This can be now already NC22: https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule
This can be now already NC22: https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule
Done
/rebase
Codacy
Lint
| Type | master | PR |
| Warnings | 85 | 85 |
| Errors | 0 | 0 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 29 | 29 |
| Correctness | 46 | 46 |
| Dodgy code | 352 | 352 |
| Experimental | 1 | 1 |
| Internationalization | 9 | 9 |
| Multithreaded correctness | 9 | 9 |
| Performance | 58 | 58 |
| Security | 28 | 28 |
| Total | 532 | 532 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10608.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.