android icon indicating copy to clipboard operation
android copied to clipboard

FDA IT.showShares: open shared section through menu

Open AlvaroBrey opened this issue 3 years ago • 3 comments

It's the "correct" way to do it and seems to prevent random Recyclerview crashes in CI: https://github.com/nextcloud/android/pull/10602/commits/9ed4d3d1ee34e8a1d4d86e7320d868e44c35bf2f

Also convert to Kotlin since we're here

  • [x] Tests written, or not not needed

AlvaroBrey avatar Aug 08 '22 08:08 AlvaroBrey

Codecov Report

Merging #10602 (6923ba3) into master (69452d8) will decrease coverage by 0.02%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #10602      +/-   ##
============================================
- Coverage     31.48%   31.45%   -0.03%     
+ Complexity     3302     3296       -6     
============================================
  Files           540      540              
  Lines         40217    40217              
  Branches       5560     5560              
============================================
- Hits          12662    12650      -12     
- Misses        25674    25687      +13     
+ Partials       1881     1880       -1     
Impacted Files Coverage Δ
...va/com/owncloud/android/utils/FilesSyncHelper.java 14.60% <0.00%> (-6.75%) :arrow_down:
...cloud/android/datamodel/UploadsStorageManager.java 66.42% <0.00%> (-5.78%) :arrow_down:
...ncloud/android/ui/activity/FolderPickerActivity.kt 27.24% <0.00%> (-4.31%) :arrow_down:
...ain/java/com/owncloud/android/db/UploadResult.java 39.74% <0.00%> (-2.57%) :arrow_down:
.../owncloud/android/ui/adapter/OCFileListDelegate.kt 49.63% <0.00%> (-1.46%) :arrow_down:
...ncloud/android/ui/fragment/OCFileListFragment.java 35.19% <0.00%> (-0.57%) :arrow_down:
...ncloud/android/operations/UploadFileOperation.java 60.39% <0.00%> (-0.50%) :arrow_down:
...loud/android/datamodel/ThumbnailsCacheManager.java 38.88% <0.00%> (-0.36%) :arrow_down:
.../owncloud/android/files/services/FileUploader.java 48.68% <0.00%> (-0.21%) :arrow_down:
...wncloud/android/providers/FileContentProvider.java 27.04% <0.00%> (+0.09%) :arrow_up:
... and 5 more

codecov[bot] avatar Aug 08 '22 08:08 codecov[bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10602.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar Aug 11 '22 09:08 github-actions[bot]

Codacy

Lint

TypemasterPR
Warnings8585
Errors00

SpotBugs

CategoryBaseNew
Bad practice2929
Correctness4646
Dodgy code353353
Experimental11
Internationalization99
Multithreaded correctness99
Performance5858
Security2828
Total533533

github-actions[bot] avatar Aug 11 '22 09:08 github-actions[bot]