android icon indicating copy to clipboard operation
android copied to clipboard

Bump targetSdkVersion to 31

Open tobiasKaminsky opened this issue 3 years ago • 4 comments
trafficstars

Ref: https://github.com/nextcloud/android/issues/9997

I tested it and beside deep link everything works so far.

  • Toast length, due to translations cannot be checked, also as sometimes the text is provide by server. When we experience problems, we need to tackle it
  • Notification still look fine: image
  • music playing (foreground service) also works. Limitation seems to be only when starting it in background.

Signed-off-by: tobiasKaminsky [email protected]

  • [x] Tests written, or not not needed

tobiasKaminsky avatar Jul 21 '22 06:07 tobiasKaminsky

Codecov Report

Merging #10545 (f98b46e) into master (cf959ee) will decrease coverage by 28.33%. The diff coverage is n/a.

:exclamation: Current head f98b46e differs from pull request most recent head 57ca106. Consider uploading reports for the commit 57ca106 to get more accurate results

@@              Coverage Diff              @@
##             master   #10545       +/-   ##
=============================================
- Coverage     31.62%    3.29%   -28.34%     
+ Complexity     3318      428     -2890     
=============================================
  Files           540      540               
  Lines         40243    40194       -49     
  Branches       5559     5554        -5     
=============================================
- Hits          12728     1323    -11405     
- Misses        25608    38789    +13181     
+ Partials       1907       82     -1825     
Impacted Files Coverage Δ
...c/main/java/com/nextcloud/client/di/ThemeModule.kt 0.00% <0.00%> (-100.00%) :arrow_down:
.../main/java/com/nextcloud/client/jobs/JobsModule.kt 0.00% <0.00%> (-100.00%) :arrow_down:
...main/java/com/nextcloud/client/core/LocalBinder.kt 0.00% <0.00%> (-100.00%) :arrow_down:
...ain/java/com/nextcloud/android/sso/QueryParam.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ain/java/com/nextcloud/client/device/DeviceInfo.kt 0.00% <0.00%> (-100.00%) :arrow_down:
...ain/java/com/owncloud/android/db/ProviderMeta.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ain/java/com/owncloud/android/utils/CsrHelper.java 0.00% <0.00%> (-100.00%) :arrow_down:
...n/java/com/nextcloud/client/device/DeviceModule.kt 0.00% <0.00%> (-100.00%) :arrow_down:
...java/com/nextcloud/client/appinfo/AppInfoModule.kt 0.00% <0.00%> (-100.00%) :arrow_down:
...java/com/nextcloud/client/files/DeepLinkHandler.kt 0.00% <0.00%> (-100.00%) :arrow_down:
... and 279 more

codecov[bot] avatar Jul 21 '22 08:07 codecov[bot]

/backport to stable-3.21

tobiasKaminsky avatar Jul 21 '22 08:07 tobiasKaminsky

/rebase

AlvaroBrey avatar Aug 22 '22 10:08 AlvaroBrey

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10545.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar Aug 22 '22 10:08 github-actions[bot]

Codacy

Lint

TypemasterPR
Warnings8585
Errors00

SpotBugs

CategoryBaseNew
Bad practice2929
Correctness4646
Dodgy code352352
Experimental11
Internationalization99
Multithreaded correctness99
Performance5858
Security2828
Total532532

github-actions[bot] avatar Aug 22 '22 10:08 github-actions[bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/5808-IT-master-10-29

nextcloud-android-bot avatar Aug 22 '22 10:08 nextcloud-android-bot