android
android copied to clipboard
Bump targetSdkVersion to 31
Ref: https://github.com/nextcloud/android/issues/9997
I tested it and beside deep link everything works so far.
- Toast length, due to translations cannot be checked, also as sometimes the text is provide by server. When we experience problems, we need to tackle it
- Notification still look fine:

- music playing (foreground service) also works. Limitation seems to be only when starting it in background.
Signed-off-by: tobiasKaminsky [email protected]
- [x] Tests written, or not not needed
Codecov Report
Merging #10545 (f98b46e) into master (cf959ee) will decrease coverage by
28.33%. The diff coverage isn/a.
:exclamation: Current head f98b46e differs from pull request most recent head 57ca106. Consider uploading reports for the commit 57ca106 to get more accurate results
@@ Coverage Diff @@
## master #10545 +/- ##
=============================================
- Coverage 31.62% 3.29% -28.34%
+ Complexity 3318 428 -2890
=============================================
Files 540 540
Lines 40243 40194 -49
Branches 5559 5554 -5
=============================================
- Hits 12728 1323 -11405
- Misses 25608 38789 +13181
+ Partials 1907 82 -1825
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...c/main/java/com/nextcloud/client/di/ThemeModule.kt | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| .../main/java/com/nextcloud/client/jobs/JobsModule.kt | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| ...main/java/com/nextcloud/client/core/LocalBinder.kt | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| ...ain/java/com/nextcloud/android/sso/QueryParam.java | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| ...ain/java/com/nextcloud/client/device/DeviceInfo.kt | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| ...ain/java/com/owncloud/android/db/ProviderMeta.java | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| ...ain/java/com/owncloud/android/utils/CsrHelper.java | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| ...n/java/com/nextcloud/client/device/DeviceModule.kt | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| ...java/com/nextcloud/client/appinfo/AppInfoModule.kt | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| ...java/com/nextcloud/client/files/DeepLinkHandler.kt | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| ... and 279 more |
/backport to stable-3.21
/rebase
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10545.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
Codacy
Lint
| Type | master | PR |
| Warnings | 85 | 85 |
| Errors | 0 | 0 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 29 | 29 |
| Correctness | 46 | 46 |
| Dodgy code | 352 | 352 |
| Experimental | 1 | 1 |
| Internationalization | 9 | 9 |
| Multithreaded correctness | 9 | 9 |
| Performance | 58 | 58 |
| Security | 28 | 28 |
| Total | 532 | 532 |
master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/5808-IT-master-10-29