After removing last favorite item show correct placeholder

[tobiasKaminsky]

trafficstars

Test

• add a file as favorited
• go to "favorites"
• unset this file
• see correct empty placeholder

Signed-off-by: tobiasKaminsky [email protected]

• [ ] Tests written, or not not needed

[github-actions[bot]]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10519.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions[bot]]

Codacy

Lint

Type	master	PR
Warnings	85	85
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	29	29
Correctness	46	46
Dodgy code	353	353
Experimental	1	1
Internationalization	9	9
Multithreaded correctness	9	9
Performance	59	59
Security	28	28
Total	534	534

[nextcloud-android-bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/5494-IT-master-10-13

[github-actions[bot]]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10519.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions[bot]]

Codacy

Lint

Type	master	PR
Warnings	76	76
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	27	27
Correctness	44	44
Dodgy code	334	334
Internationalization	9	9
Multithreaded correctness	9	9
Performance	58	58
Security	18	18
Total	499	499

[codecov[bot]]

Codecov Report

Merging #10519 (cf28c7e) into master (6178a14) will increase coverage by 0.20%. The diff coverage is 0.00%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #10519      +/-   ##
============================================
+ Coverage     31.36%   31.57%   +0.20%     
- Complexity     3408     3431      +23     
============================================
  Files           576      576              
  Lines         42121    42122       +1     
  Branches       5684     5684              
============================================
+ Hits          13212    13300      +88     
+ Misses        26938    26858      -80     
+ Partials       1971     1964       -7     

Impacted Files	Coverage Δ
...ncloud/android/ui/fragment/OCFileListFragment.java	39.82% <0.00%> (-0.05%)	:arrow_down:
.../owncloud/android/datamodel/MediaFoldersModel.java	40.00% <0.00%> (-20.00%)	:arrow_down:
...ncloud/android/ui/activity/FolderPickerActivity.kt	29.93% <0.00%> (-7.83%)	:arrow_down:
...nextcloud/client/jobs/MediaFoldersDetectionWork.kt	22.87% <0.00%> (-5.23%)	:arrow_down:
.../third_parties/daveKoeller/AlphanumComparator.java	86.90% <0.00%> (-1.20%)	:arrow_down:
...loud/android/ui/fragment/ExtendedListFragment.java	53.35% <0.00%> (-1.07%)	:arrow_down:
...oud/android/operations/RefreshFolderOperation.java	77.38% <0.00%> (-1.07%)	:arrow_down:
...xtcloud/client/account/UserAccountManagerImpl.java	69.33% <0.00%> (-0.67%)	:arrow_down:
...cloud/android/ui/activity/SyncedFoldersActivity.kt	20.53% <0.00%> (-0.45%)	:arrow_down:
...cloud/android/ui/activity/FileDisplayActivity.java	28.99% <0.00%> (-0.09%)	:arrow_down:
... and 11 more