android
android copied to clipboard
analysis: use github job summary instead of comment
See https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/
- [x] Tests written, or not not needed
How it looks:https://github.com/nextcloud/android/actions/runs/3748919814 How to get to it: click "details" next to the analysis check, then click "summary" in the left bar
Codecov Report
Merging #10345 (5428cf7) into master (ca374aa) will decrease coverage by
0.00%. The diff coverage isn/a.
Additional details and impacted files
@@ Coverage Diff @@
## master #10345 +/- ##
============================================
- Coverage 3.21% 3.20% -0.01%
+ Complexity 427 425 -2
============================================
Files 565 565
Lines 41577 41577
Branches 5635 5635
============================================
- Hits 1336 1333 -3
- Misses 40158 40160 +2
- Partials 83 84 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| .../third_parties/daveKoeller/AlphanumComparator.java | 84.52% <0.00%> (-3.58%) |
:arrow_down: |
| ...cloud/android/ui/activity/SyncedFoldersActivity.kt | 5.35% <0.00%> (ø) |
@tobiasKaminsky let me know what you think. This will let us have the summary for third-party PRs as well (comment posting doesn't work there), and will remove the need for comment handling logic. But, it is less immediately obvious as it requires 2 clicks to get to.
Another option would be to post the comment if possible, but also still post the job summary, to have it in the cases where the comment does not work.
@tobiasKaminsky :ping_pong:
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10345.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10345-Screenshot-blue-Light-13-01
Codacy
Lint
| Type | master | PR |
| Warnings | 82 | 82 |
| Errors | 0 | 0 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 27 | 27 |
| Correctness | 44 | 44 |
| Dodgy code | 335 | 335 |
| Internationalization | 9 | 9 |
| Multithreaded correctness | 9 | 9 |
| Performance | 58 | 58 |
| Security | 18 | 18 |
| Total | 500 | 500 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10345.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.