android icon indicating copy to clipboard operation
android copied to clipboard

analysis: use github job summary instead of comment

Open AlvaroBrey opened this issue 3 years ago • 4 comments

See https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/

  • [x] Tests written, or not not needed

AlvaroBrey avatar Jun 06 '22 09:06 AlvaroBrey

How it looks:https://github.com/nextcloud/android/actions/runs/3748919814 How to get to it: click "details" next to the analysis check, then click "summary" in the left bar

AlvaroBrey avatar Jun 06 '22 10:06 AlvaroBrey

Codecov Report

Merging #10345 (5428cf7) into master (ca374aa) will decrease coverage by 0.00%. The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10345      +/-   ##
============================================
- Coverage      3.21%    3.20%   -0.01%     
+ Complexity      427      425       -2     
============================================
  Files           565      565              
  Lines         41577    41577              
  Branches       5635     5635              
============================================
- Hits           1336     1333       -3     
- Misses        40158    40160       +2     
- Partials         83       84       +1     
Impacted Files Coverage Δ
.../third_parties/daveKoeller/AlphanumComparator.java 84.52% <0.00%> (-3.58%) :arrow_down:
...cloud/android/ui/activity/SyncedFoldersActivity.kt 5.35% <0.00%> (ø)

codecov[bot] avatar Jun 06 '22 10:06 codecov[bot]

@tobiasKaminsky let me know what you think. This will let us have the summary for third-party PRs as well (comment posting doesn't work there), and will remove the need for comment handling logic. But, it is less immediately obvious as it requires 2 clicks to get to.

Another option would be to post the comment if possible, but also still post the job summary, to have it in the cases where the comment does not work.

AlvaroBrey avatar Jun 07 '22 07:06 AlvaroBrey

@tobiasKaminsky :ping_pong:

AlvaroBrey avatar Jun 28 '22 09:06 AlvaroBrey

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10345.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar Oct 05 '22 12:10 github-actions[bot]

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/10345-Screenshot-blue-Light-13-01

github-actions[bot] avatar Oct 05 '22 13:10 github-actions[bot]

Codacy

Lint

TypemasterPR
Warnings8282
Errors00

SpotBugs

CategoryBaseNew
Bad practice2727
Correctness4444
Dodgy code335335
Internationalization99
Multithreaded correctness99
Performance5858
Security1818
Total500500

github-actions[bot] avatar Dec 21 '22 11:12 github-actions[bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10345.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

github-actions[bot] avatar Dec 21 '22 11:12 github-actions[bot]