android-library icon indicating copy to clipboard operation
android-library copied to clipboard

Parse favorite attribute for OCShare on NC 25+

Open tobiasKaminsky opened this issue 3 years ago • 5 comments

TODO

  • [x] wait for https://github.com/nextcloud/server/pull/34133 to be merged
  • [ ] wait for https://github.com/nextcloud/server/pull/34223

Requires: https://github.com/nextcloud/server/pull/34133

Signed-off-by: tobiasKaminsky [email protected]

tobiasKaminsky avatar Sep 19 '22 10:09 tobiasKaminsky

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 40
Total 150

SpotBugs (master)

Warning Type Number
Bad practice Warnings 17
Correctness Warnings 36
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 1
Dodgy code Warnings 45
Total 164

SpotBugs increased!

github-actions[bot] avatar Sep 22 '22 07:09 github-actions[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 40
Total 150

SpotBugs (master)

Warning Type Number
Bad practice Warnings 17
Correctness Warnings 36
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 1
Dodgy code Warnings 45
Total 164

SpotBugs increased!

github-actions[bot] avatar Sep 23 '22 10:09 github-actions[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 40
Total 150

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 39
Total 149

SpotBugs increased!

github-actions[bot] avatar Sep 23 '22 13:09 github-actions[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 39
Total 149

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 39
Total 149

github-actions[bot] avatar Sep 23 '22 14:09 github-actions[bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1352-IT-master-15-37

nextcloud-android-bot avatar Sep 23 '22 15:09 nextcloud-android-bot

/rebase

AlvaroBrey avatar Nov 17 '22 12:11 AlvaroBrey

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

github-actions[bot] avatar Nov 17 '22 12:11 github-actions[bot]

@tobiasKaminsky as this is kinda old I didn't wanna merge without you having a look at it, feel free to merge when you want

AlvaroBrey avatar Nov 30 '22 14:11 AlvaroBrey

I created a branch on files for it: https://github.com/nextcloud/android/pull/11138

tobiasKaminsky avatar Dec 05 '22 08:12 tobiasKaminsky

/rebase

AlvaroBrey avatar Dec 13 '22 11:12 AlvaroBrey

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

github-actions[bot] avatar Dec 13 '22 11:12 github-actions[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

github-actions[bot] avatar Dec 13 '22 13:12 github-actions[bot]