change key handling
Needed by https://github.com/nextcloud/android/pull/10713
Signed-off-by: tobiasKaminsky [email protected]
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 39 |
| Total | 149 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 17 |
| Correctness Warnings | 36 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 13 |
| Security Warnings | 1 |
| Dodgy code Warnings | 45 |
| Total | 164 |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 39 |
| Total | 149 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 17 |
| Correctness Warnings | 36 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 13 |
| Security Warnings | 1 |
| Dodgy code Warnings | 45 |
| Total | 164 |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 39 |
| Total | 149 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 17 |
| Correctness Warnings | 36 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 13 |
| Security Warnings | 1 |
| Dodgy code Warnings | 45 |
| Total | 164 |
stable-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1326-IT-stable-15-04
Rebased and conflicts fixed
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
/rebase
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
Codecov Report
Merging #959 (be24e92) into master (78f36c8) will increase coverage by
0.28%. The diff coverage is49.56%.
:exclamation: Current head be24e92 differs from pull request most recent head f677f4e. Consider uploading reports for the commit f677f4e to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #959 +/- ##
==========================================
+ Coverage 48.70% 48.99% +0.28%
==========================================
Files 171 178 +7
Lines 6611 6687 +76
Branches 881 886 +5
==========================================
+ Hits 3220 3276 +56
- Misses 2922 2940 +18
- Partials 469 471 +2
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...oid/lib/resources/dashboard/DashboardWidgetList.kt | 0.00% <0.00%> (ø) |
|
| ...diting/DirectEditingCreateFileRemoteOperation.java | 76.47% <ø> (ø) |
|
| ...ctEditingObtainListOfTemplatesRemoteOperation.java | 68.00% <ø> (ø) |
|
| ...ectediting/DirectEditingObtainRemoteOperation.java | 63.63% <ø> (ø) |
|
| ...tediting/DirectEditingOpenFileRemoteOperation.java | 81.48% <ø> (ø) |
|
| ...b/resources/profile/GetHoverCardRemoteOperation.kt | 62.50% <ø> (ø) |
|
| ...es/search/UnifiedSearchProvidersRemoteOperation.kt | 48.14% <ø> (ø) |
|
| ...rces/users/GenerateAppPasswordRemoteOperation.java | 77.27% <ø> (ø) |
|
| ...ace/RichWorkspaceDirectEditingRemoteOperation.java | 72.41% <ø> (ø) |
|
| .../main/java/com/nextcloud/common/NextcloudClient.kt | 57.14% <ø> (ø) |
|
| ... and 42 more |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |