android-library icon indicating copy to clipboard operation
android-library copied to clipboard

Switching to dav4jvm

Open tobiasKaminsky opened this issue 3 years ago • 8 comments
trafficstars

Heavily under construction 🚧 If you have any feedback, please comment :)

Signed-off-by: tobiasKaminsky [email protected]

tobiasKaminsky avatar May 02 '22 12:05 tobiasKaminsky

@AlvaroBrey if you have a bit of time, any feedback would be great 💙

tobiasKaminsky avatar May 05 '22 13:05 tobiasKaminsky

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 42
Total 152

SpotBugs (master)

Warning Type Number
Bad practice Warnings 17
Correctness Warnings 36
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 1
Dodgy code Warnings 45
Total 164

SpotBugs increased!

github-actions[bot] avatar Jul 01 '22 08:07 github-actions[bot]

Codecov Report

Attention: Patch coverage is 65.97180% with 555 lines in your changes missing coverage. Please review.

Project coverage is 50.32%. Comparing base (0c3c568) to head (924bdd5). Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #881      +/-   ##
============================================
+ Coverage     49.20%   50.32%   +1.12%     
- Complexity     1001     1136     +135     
============================================
  Files           208      256      +48     
  Lines          7819     8373     +554     
  Branches       1017     1107      +90     
============================================
+ Hits           3847     4214     +367     
- Misses         3419     3548     +129     
- Partials        553      611      +58     
Files Coverage Δ
...ces/groupfolders/GetGroupfoldersRemoteOperation.kt 61.29% <100.00%> (ø)
...b/resources/profile/GetHoverCardRemoteOperation.kt 57.14% <100.00%> (ø)
...ry/src/main/java/com/nextcloud/common/DavMethod.kt 100.00% <100.00%> (ø)
.../main/java/com/nextcloud/common/NextcloudClient.kt 50.45% <100.00%> (+3.92%) :arrow_up:
...main/java/com/nextcloud/common/OkHttpMethodBase.kt 64.81% <ø> (-1.26%) :arrow_down:
.../java/com/nextcloud/common/UserAgentInterceptor.kt 100.00% <100.00%> (ø)
...n/java/com/nextcloud/extensions/ArrayExtensions.kt 100.00% <100.00%> (ø)
...in/java/com/nextcloud/operations/PropFindResult.kt 100.00% <100.00%> (ø)
...rc/main/java/com/nextcloud/operations/PutMethod.kt 83.33% <100.00%> (+11.90%) :arrow_up:
...d/android/lib/common/network/ExtendedProperties.kt 100.00% <100.00%> (ø)
... and 82 more

... and 3 files with indirect coverage changes

codecov[bot] avatar Jul 01 '22 08:07 codecov[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 44
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 3
Dodgy code Warnings 34
Total 148

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs increased!

github-actions[bot] avatar Oct 14 '22 05:10 github-actions[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 44
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 3
Dodgy code Warnings 34
Total 148

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs increased!

github-actions[bot] avatar Nov 01 '22 12:11 github-actions[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 44
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 3
Dodgy code Warnings 34
Total 148

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs increased!

github-actions[bot] avatar Nov 01 '22 12:11 github-actions[bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1421-IT-master-12-11

nextcloud-android-bot avatar Nov 01 '22 12:11 nextcloud-android-bot

stable-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1421-IT-stable-12-13

nextcloud-android-bot avatar Nov 01 '22 12:11 nextcloud-android-bot

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 44
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 3
Dodgy code Warnings 33
Total 147

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs increased!

github-actions[bot] avatar Nov 03 '22 10:11 github-actions[bot]

stable-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1428-IT-stable-11-43

nextcloud-android-bot avatar Nov 03 '22 11:11 nextcloud-android-bot

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 44
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 3
Dodgy code Warnings 33
Total 147

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs increased!

github-actions[bot] avatar Dec 12 '22 15:12 github-actions[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 44
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 3
Dodgy code Warnings 33
Total 147

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs increased!

github-actions[bot] avatar Dec 13 '22 06:12 github-actions[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 44
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 3
Dodgy code Warnings 33
Total 147

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs increased!

github-actions[bot] avatar Dec 13 '22 06:12 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2627
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance89
Security02
Total161165

SpotBugs increased!

github-actions[bot] avatar Jan 30 '24 13:01 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2627
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance89
Security02
Total161165

SpotBugs increased!

github-actions[bot] avatar Feb 12 '24 22:02 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3431
Dodgy code2627
Internationalization64
Malicious code vulnerability4944
Multithreaded correctness33
Performance88
Security02
Total161154

github-actions[bot] avatar Jun 18 '24 10:06 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3431
Dodgy code2627
Internationalization64
Malicious code vulnerability4944
Multithreaded correctness33
Performance88
Security02
Total161154

github-actions[bot] avatar Jun 18 '24 12:06 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3431
Dodgy code2627
Internationalization64
Malicious code vulnerability4944
Multithreaded correctness33
Performance88
Security02
Total161154

github-actions[bot] avatar Jun 24 '24 12:06 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3431
Dodgy code2627
Internationalization64
Malicious code vulnerability4944
Multithreaded correctness33
Performance89
Security02
Total161155

github-actions[bot] avatar Jun 24 '24 12:06 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3431
Dodgy code2627
Internationalization64
Malicious code vulnerability4944
Multithreaded correctness33
Performance89
Security02
Total161155

github-actions[bot] avatar Jun 26 '24 13:06 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3431
Dodgy code2627
Internationalization64
Malicious code vulnerability4944
Multithreaded correctness33
Performance89
Security02
Total161155

github-actions[bot] avatar Jun 26 '24 13:06 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3431
Dodgy code2627
Internationalization64
Malicious code vulnerability4944
Multithreaded correctness33
Performance88
Security02
Total161154

github-actions[bot] avatar Jun 26 '24 15:06 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3431
Dodgy code2627
Internationalization64
Malicious code vulnerability4944
Multithreaded correctness33
Performance88
Security02
Total161154

github-actions[bot] avatar Jun 27 '24 14:06 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3431
Dodgy code2627
Internationalization64
Malicious code vulnerability4944
Multithreaded correctness33
Performance88
Security02
Total161154

github-actions[bot] avatar Jul 02 '24 06:07 github-actions[bot]