Expose share by mail

[tobiasKaminsky]

trafficstars

Signed-off-by: tobiasKaminsky [email protected]

[AlvaroBrey]

Change looks good, but tests are failing

[tobiasKaminsky]

stable-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/581-IT-stable-06-59

@AlvaroBrey do you have an idea why suddenly so many tests on stable, but only on stable, fail?

[AlvaroBrey]

stable-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/581-IT-stable-06-59

@AlvaroBrey do you have an idea why suddenly so many tests on stable, but only on stable, fail?

It seems that most of the crashes are related to OCCapability. Any recent changes there?

[tobiasKaminsky]

All solved except of lint, which complains as another dependency is outdated.

[tobiasKaminsky]

/rebase

[nextcloud-android-bot]

Lint

Type	master	PR
Warnings	1	1
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	38
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	13
Security Warnings	1
Dodgy code Warnings	40
Total	122

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	14
Correctness Warnings	38
Internationalization Warnings	6
Malicious code vulnerability Warnings	7
Multithreaded correctness Warnings	3
Performance Warnings	13
Security Warnings	1
Dodgy code Warnings	40
Total	122

[codecov[bot]]

Codecov Report

Merging #735 (20b435d) into master (012db19) will decrease coverage by 2.11%. The diff coverage is 71.42%.

:exclamation: Current head 20b435d differs from pull request most recent head c6c209c. Consider uploading reports for the commit c6c209c to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #735      +/-   ##
============================================
- Coverage     48.57%   46.47%   -2.11%     
============================================
  Files           200      164      -36     
  Lines          7697     6361    -1336     
  Branches        989      835     -154     
============================================
- Hits           3739     2956     -783     
+ Misses         3438     2965     -473     
+ Partials        520      440      -80     

Files	Coverage Δ
...oud/android/lib/resources/status/OCCapability.java	59.63% <100.00%> (ø)
...sources/status/GetCapabilitiesRemoteOperation.java	48.83% <66.66%> (ø)

... and 362 files with indirect coverage changes

[github-actions[bot]]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161

[github-actions[bot]]

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	3	3
Performance	8	8
Total	161	161