android-library icon indicating copy to clipboard operation
android-library copied to clipboard

Retrieve localId via webdav

Open tobiasKaminsky opened this issue 4 years ago • 6 comments

Needed for https://github.com/nextcloud/android/pull/8643 Signed-off-by: tobiasKaminsky [email protected]

tobiasKaminsky avatar Jun 30 '21 07:06 tobiasKaminsky

IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/296-IT-master

nextcloud-android-bot avatar Jun 30 '21 08:06 nextcloud-android-bot

Lint

TypemasterPR
Warnings13
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings40
Total126

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings40
Total126

Lint increased!

nextcloud-android-bot avatar Jul 02 '21 07:07 nextcloud-android-bot

IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/318-IT-master

nextcloud-android-bot avatar Jul 02 '21 07:07 nextcloud-android-bot

Lint

TypemasterPR
Warnings11
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings40
Total126

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings40
Total126

nextcloud-android-bot avatar Jul 05 '21 12:07 nextcloud-android-bot

IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/325-IT-master

nextcloud-android-bot avatar Jul 06 '21 05:07 nextcloud-android-bot

Lint

TypemasterPR
Warnings11
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings40
Total126

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings40
Total126

nextcloud-android-bot avatar Jul 06 '21 05:07 nextcloud-android-bot

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

github-actions[bot] avatar Dec 02 '22 10:12 github-actions[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

github-actions[bot] avatar Dec 02 '22 11:12 github-actions[bot]

@AlvaroBrey

java.lang.AssertionError: expected: java.lang.Long<69> but was: java.lang.String<69>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:120)
at org.junit.Assert.assertEquals(Assert.java:146)
at com.nextcloud.android.lib.resources.search.UnifiedSearchRemoteOperationIT.filesSearch(UnifiedSearchRemoteOperationIT.kt:78)

Attributes is Map<String, String>. Thus I dare not to touch it.

I now fixed the test, by converting long to String.

tobiasKaminsky avatar Dec 02 '22 12:12 tobiasKaminsky

Codecov Report

Merging #651 (e96ba95) into master (bac776f) will increase coverage by 0.48%. The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
+ Coverage   48.87%   49.35%   +0.48%     
==========================================
  Files         179      179              
  Lines        6726     6739      +13     
  Branches      894      895       +1     
==========================================
+ Hits         3287     3326      +39     
+ Misses       2972     2945      -27     
- Partials      467      468       +1     
Impacted Files Coverage Δ
.../java/com/nextcloud/common/NextcloudUriDelegate.kt 83.33% <ø> (ø)
...om/owncloud/android/lib/common/OwnCloudClient.java 42.85% <ø> (ø)
...urces/files/RestoreFileVersionRemoteOperation.java 0.00% <0.00%> (ø)
...oid/lib/resources/trashbin/model/TrashbinFile.java 0.00% <0.00%> (ø)
...urces/activities/GetActivitiesRemoteOperation.java 35.89% <11.11%> (ø)
...android/lib/resources/files/model/FileVersion.java 33.33% <33.33%> (-2.16%) :arrow_down:
...id/lib/resources/e2ee/LockFileRemoteOperation.java 63.88% <50.00%> (ø)
...sources/files/ReadFileVersionsRemoteOperation.java 58.97% <55.55%> (ø)
.../android/lib/resources/files/model/RemoteFile.java 45.80% <60.00%> (+0.77%) :arrow_up:
...ncloud/android/lib/common/network/WebdavEntry.java 79.68% <85.71%> (+1.59%) :arrow_up:
... and 17 more

codecov[bot] avatar Dec 02 '22 13:12 codecov[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

github-actions[bot] avatar Dec 02 '22 13:12 github-actions[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

github-actions[bot] avatar Dec 02 '22 13:12 github-actions[bot]

/rebase

AlvaroBrey avatar Dec 15 '22 19:12 AlvaroBrey

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

github-actions[bot] avatar Dec 15 '22 19:12 github-actions[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

github-actions[bot] avatar Jan 17 '23 08:01 github-actions[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

github-actions[bot] avatar Jan 17 '23 11:01 github-actions[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

github-actions[bot] avatar Jan 18 '23 10:01 github-actions[bot]

yay! :partying_face:

AlvaroBrey avatar Jan 19 '23 08:01 AlvaroBrey