android-library
android-library copied to clipboard
Retrieve localId via webdav
Needed for https://github.com/nextcloud/android/pull/8643 Signed-off-by: tobiasKaminsky [email protected]
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/296-IT-master
Lint
| Type | master | PR |
| Warnings | 1 | 3 |
| Errors | 0 | 0 |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 14 |
| Correctness Warnings | 38 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 7 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 17 |
| Security Warnings | 1 |
| Dodgy code Warnings | 40 |
| Total | 126 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 14 |
| Correctness Warnings | 38 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 7 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 17 |
| Security Warnings | 1 |
| Dodgy code Warnings | 40 |
| Total | 126 |
Lint increased!
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/318-IT-master
Lint
| Type | master | PR |
| Warnings | 1 | 1 |
| Errors | 0 | 0 |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 14 |
| Correctness Warnings | 38 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 7 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 17 |
| Security Warnings | 1 |
| Dodgy code Warnings | 40 |
| Total | 126 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 14 |
| Correctness Warnings | 38 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 7 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 17 |
| Security Warnings | 1 |
| Dodgy code Warnings | 40 |
| Total | 126 |
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/325-IT-master
Lint
| Type | master | PR |
| Warnings | 1 | 1 |
| Errors | 0 | 0 |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 14 |
| Correctness Warnings | 38 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 7 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 17 |
| Security Warnings | 1 |
| Dodgy code Warnings | 40 |
| Total | 126 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 14 |
| Correctness Warnings | 38 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 7 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 17 |
| Security Warnings | 1 |
| Dodgy code Warnings | 40 |
| Total | 126 |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
@AlvaroBrey
java.lang.AssertionError: expected: java.lang.Long<69> but was: java.lang.String<69>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:120)
at org.junit.Assert.assertEquals(Assert.java:146)
at com.nextcloud.android.lib.resources.search.UnifiedSearchRemoteOperationIT.filesSearch(UnifiedSearchRemoteOperationIT.kt:78)
Attributes is Map<String, String>. Thus I dare not to touch it.
I now fixed the test, by converting long to String.
Codecov Report
Merging #651 (e96ba95) into master (bac776f) will increase coverage by
0.48%. The diff coverage is50.00%.
Additional details and impacted files
@@ Coverage Diff @@
## master #651 +/- ##
==========================================
+ Coverage 48.87% 49.35% +0.48%
==========================================
Files 179 179
Lines 6726 6739 +13
Branches 894 895 +1
==========================================
+ Hits 3287 3326 +39
+ Misses 2972 2945 -27
- Partials 467 468 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| .../java/com/nextcloud/common/NextcloudUriDelegate.kt | 83.33% <ø> (ø) |
|
| ...om/owncloud/android/lib/common/OwnCloudClient.java | 42.85% <ø> (ø) |
|
| ...urces/files/RestoreFileVersionRemoteOperation.java | 0.00% <0.00%> (ø) |
|
| ...oid/lib/resources/trashbin/model/TrashbinFile.java | 0.00% <0.00%> (ø) |
|
| ...urces/activities/GetActivitiesRemoteOperation.java | 35.89% <11.11%> (ø) |
|
| ...android/lib/resources/files/model/FileVersion.java | 33.33% <33.33%> (-2.16%) |
:arrow_down: |
| ...id/lib/resources/e2ee/LockFileRemoteOperation.java | 63.88% <50.00%> (ø) |
|
| ...sources/files/ReadFileVersionsRemoteOperation.java | 58.97% <55.55%> (ø) |
|
| .../android/lib/resources/files/model/RemoteFile.java | 45.80% <60.00%> (+0.77%) |
:arrow_up: |
| ...ncloud/android/lib/common/network/WebdavEntry.java | 79.68% <85.71%> (+1.59%) |
:arrow_up: |
| ... and 17 more |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
/rebase
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (new)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
SpotBugs (master)
| Warning Type | Number |
|---|---|
| Bad practice Warnings | 10 |
| Correctness Warnings | 35 |
| Internationalization Warnings | 6 |
| Malicious code vulnerability Warnings | 43 |
| Multithreaded correctness Warnings | 3 |
| Performance Warnings | 12 |
| Security Warnings | 1 |
| Dodgy code Warnings | 31 |
| Total | 141 |
yay! :partying_face: