android-library icon indicating copy to clipboard operation
android-library copied to clipboard

Interceptor

Open tobiasKaminsky opened this issue 5 years ago • 2 comments

This adds possibility to add an interceptor to new OKHttpClient so that we can use pre-defined responses and do not have to use the server.

It is for now just a discussion. I will open up a corresponding PR on files.

Ref: https://medium.com/ki-labs-engineering/an-easy-way-to-mock-an-api-response-using-retrofit-okhttp-and-interceptor-7968e1f0d050

tobiasKaminsky avatar Jun 16 '20 10:06 tobiasKaminsky

Lint

TypemasterPR
Warnings22
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings41
Total127

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings14
Correctness Warnings38
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings1
Dodgy code Warnings41
Total127

nextcloud-android-bot avatar Jun 16 '20 10:06 nextcloud-android-bot

Codecov Report

Merging #454 into master will decrease coverage by 0.00%. The diff coverage is 38.46%.

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   39.50%   39.50%   -0.01%     
==========================================
  Files         136      136              
  Lines        5895     5901       +6     
  Branches      771      773       +2     
==========================================
+ Hits         2329     2331       +2     
- Misses       3218     3222       +4     
  Partials      348      348              
Impacted Files Coverage Δ
...loud/android/lib/common/OwnCloudClientFactory.java 12.50% <0.00%> (-0.71%) :arrow_down:
.../main/java/com/nextcloud/common/NextcloudClient.kt 50.00% <62.50%> (-2.46%) :arrow_down:
...wncloud/android/lib/resources/files/FileUtils.java 85.71% <0.00%> (+14.28%) :arrow_up:

codecov[bot] avatar Jun 16 '20 10:06 codecov[bot]