android-library icon indicating copy to clipboard operation
android-library copied to clipboard

Use REPORT for favorite search

Open tobiasKaminsky opened this issue 6 years ago • 3 comments

Waits for: ~~https://github.com/nextcloud/server/issues/15029~~ ~~https://github.com/nextcloud/3rdparty/pull/264~~ https://github.com/nextcloud/server/issues/17586

Signed-off-by: tobiasKaminsky [email protected]

tobiasKaminsky avatar Apr 10 '19 11:04 tobiasKaminsky

Hmm, looking at the number of commits it seems a rebase since this is still in development would trim the number of changes quite a bit :)

AndyScherzinger avatar Aug 08 '19 13:08 AndyScherzinger

Codecov Report

Merging #273 into master will decrease coverage by 8.71%. The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   31.62%   22.91%   -8.72%     
==========================================
  Files         120      118       -2     
  Lines        5280     5259      -21     
  Branches      704      703       -1     
==========================================
- Hits         1670     1205     -465     
- Misses       3387     3930     +543     
+ Partials      223      124      -99
Impacted Files Coverage Δ
...ncloud/android/lib/common/network/WebdavEntry.java 73.65% <ø> (+1.29%) :arrow_up:
...b/resources/files/GetFavoritesRemoteOperation.java 94.11% <94.11%> (ø)
...d/android/lib/resources/shares/ShareXMLParser.java 0% <0%> (-83.44%) :arrow_down:
...b/resources/shares/RemoveShareRemoteOperation.java 0% <0%> (-72%) :arrow_down:
...lib/resources/shares/GetSharesRemoteOperation.java 0% <0%> (-69.57%) :arrow_down:
...ncloud/android/lib/resources/shares/ShareType.java 0% <0%> (-69.57%) :arrow_down:
...b/resources/shares/CreateShareRemoteOperation.java 0% <0%> (-68%) :arrow_down:
...resources/files/ExistenceCheckRemoteOperation.java 0% <0%> (-61.12%) :arrow_down:
...d/lib/resources/files/CopyFileRemoteOperation.java 0% <0%> (-58.54%) :arrow_down:
...oud/android/lib/resources/status/OCCapability.java 0% <0%> (-50.52%) :arrow_down:
... and 27 more

codecov[bot] avatar Oct 17 '19 06:10 codecov[bot]

Lint

TypemasterPR
Warnings00
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings15
Correctness Warnings39
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings60
Total164

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings15
Correctness Warnings39
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings59
Total163

SpotBugs increased!

nextcloud-android-bot avatar Oct 17 '19 06:10 nextcloud-android-bot