Deprecate OwncloudClient - Sharing
This is one of a series of pull requests which aim to replace all instances of OwnCloudClient with NextcloudClient. The reason for this change is that the newer NextcloudClient uses OkHttp, replacing the outdated Jackrabbit methods.
Specifically, this pull request implements the following:
- changes related to sharing
- server status and info operations
Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 35 | 35 |
| Correctness | 34 | 33 |
| Dodgy code | 26 | 28 |
| Internationalization | 6 | 6 |
| Malicious code vulnerability | 49 | 50 |
| Multithreaded correctness | 3 | 3 |
| Performance | 8 | 8 |
| Total | 161 | 163 |
SpotBugs increased!
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 35 | 35 |
| Correctness | 34 | 33 |
| Dodgy code | 26 | 28 |
| Internationalization | 6 | 6 |
| Malicious code vulnerability | 49 | 50 |
| Multithreaded correctness | 3 | 3 |
| Performance | 8 | 8 |
| Total | 161 | 163 |
SpotBugs increased!
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 35 | 35 |
| Correctness | 34 | 35 |
| Dodgy code | 26 | 29 |
| Internationalization | 6 | 6 |
| Malicious code vulnerability | 49 | 51 |
| Multithreaded correctness | 3 | 3 |
| Performance | 8 | 8 |
| Total | 161 | 167 |
SpotBugs increased!
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 35 | 35 |
| Correctness | 34 | 35 |
| Dodgy code | 26 | 29 |
| Internationalization | 6 | 6 |
| Malicious code vulnerability | 49 | 51 |
| Multithreaded correctness | 3 | 3 |
| Performance | 8 | 8 |
| Total | 161 | 167 |
SpotBugs increased!
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 35 | 35 |
| Correctness | 34 | 35 |
| Dodgy code | 26 | 29 |
| Internationalization | 6 | 6 |
| Malicious code vulnerability | 49 | 51 |
| Multithreaded correctness | 3 | 3 |
| Performance | 8 | 8 |
| Total | 161 | 167 |
SpotBugs increased!
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 35 | 35 |
| Correctness | 34 | 35 |
| Dodgy code | 26 | 29 |
| Internationalization | 6 | 6 |
| Malicious code vulnerability | 49 | 51 |
| Multithreaded correctness | 3 | 3 |
| Performance | 8 | 8 |
| Total | 161 | 167 |
SpotBugs increased!
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 35 | 35 |
| Correctness | 34 | 35 |
| Dodgy code | 26 | 29 |
| Internationalization | 6 | 6 |
| Malicious code vulnerability | 49 | 51 |
| Multithreaded correctness | 3 | 3 |
| Performance | 8 | 8 |
| Total | 161 | 167 |
SpotBugs increased!
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 35 | 35 |
| Correctness | 34 | 33 |
| Dodgy code | 26 | 27 |
| Internationalization | 6 | 6 |
| Malicious code vulnerability | 49 | 49 |
| Multithreaded correctness | 3 | 3 |
| Performance | 8 | 8 |
| Total | 161 | 161 |
Codecov Report
Attention: Patch coverage is 27.55906% with 184 lines in your changes missing coverage. Please review.
Project coverage is 48.11%. Comparing base (
0c3c568) to head (fa63146).
Additional details and impacted files
@@ Coverage Diff @@
## master #1294 +/- ##
============================================
- Coverage 49.20% 48.11% -1.09%
- Complexity 1001 1004 +3
============================================
Files 208 208
Lines 7819 8052 +233
Branches 1017 1057 +40
============================================
+ Hits 3847 3874 +27
- Misses 3419 3613 +194
- Partials 553 565 +12
| Files | Coverage Δ | |
|---|---|---|
| ...loud/android/lib/common/accounts/AccountUtils.java | 5.00% <ø> (ø) |
|
| ...cloud/android/lib/resources/shares/ShareUtils.java | 33.33% <100.00%> (+33.33%) |
:arrow_up: |
| ...droid/lib/common/OwnCloudAnonymousCredentials.java | 37.50% <0.00%> (ø) |
|
| ...b/resources/shares/CreateShareRemoteOperation.java | 68.53% <82.35%> (-11.47%) |
:arrow_down: |
| ...lib/resources/shares/GetSharesRemoteOperation.java | 67.39% <72.72%> (-7.61%) |
:arrow_down: |
| ...om/owncloud/android/lib/common/OwnCloudClient.java | 40.95% <12.50%> (-3.49%) |
:arrow_down: |
| ...b/resources/shares/RemoveShareRemoteOperation.java | 39.47% <11.11%> (-28.71%) |
:arrow_down: |
| .../lib/resources/shares/GetShareRemoteOperation.java | 38.09% <19.04%> (-32.74%) |
:arrow_down: |
| ...ources/shares/GetSharesForFileRemoteOperation.java | 0.00% <0.00%> (ø) |
|
| ...b/resources/shares/UpdateShareRemoteOperation.java | 33.60% <32.14%> (-26.97%) |
:arrow_down: |
| ... and 1 more |