android-library icon indicating copy to clipboard operation
android-library copied to clipboard

Deprecate OwncloudClient - DirectEditing

Open ZetaTom opened this issue 2 years ago • 3 comments

This is one of a series of pull requests which aim to replace all instances of OwnCloudClient with NextcloudClient. The reason for this change is that the newer NextcloudClient uses OkHttp, replacing the outdated Jackrabbit methods.

Specifically, this pull request implements the following:

  • changes related to direct editing
  • see #1271

ZetaTom avatar Dec 11 '23 10:12 ZetaTom

Codecov Report

Attention: Patch coverage is 71.79487% with 11 lines in your changes missing coverage. Please review.

Project coverage is 49.25%. Comparing base (cda1b08) to head (4a78745).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1273      +/-   ##
============================================
- Coverage     49.28%   49.25%   -0.04%     
- Complexity     1002     1003       +1     
============================================
  Files           208      208              
  Lines          7830     7823       -7     
  Branches       1015     1015              
============================================
- Hits           3859     3853       -6     
- Misses         3417     3418       +1     
+ Partials        554      552       -2     
Files Coverage Δ
...ectediting/DirectEditingObtainRemoteOperation.java 60.86% <50.00%> (+0.86%) :arrow_up:
...tediting/DirectEditingOpenFileRemoteOperation.java 80.76% <83.33%> (-0.72%) :arrow_down:
...diting/DirectEditingCreateFileRemoteOperation.java 78.12% <76.92%> (+1.65%) :arrow_up:
...ctEditingObtainListOfTemplatesRemoteOperation.java 64.00% <60.00%> (+1.03%) :arrow_up:

... and 3 files with indirect coverage changes

codecov[bot] avatar Dec 12 '23 14:12 codecov[bot]

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

github-actions[bot] avatar Dec 26 '23 02:12 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

github-actions[bot] avatar Jan 30 '24 10:01 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

github-actions[bot] avatar Jun 10 '24 13:06 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

github-actions[bot] avatar Jun 10 '24 14:06 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

github-actions[bot] avatar Jun 11 '24 10:06 github-actions[bot]