android-library icon indicating copy to clipboard operation
android-library copied to clipboard

Deprecate OwncloudClient - Notifications

Open ZetaTom opened this issue 2 years ago • 3 comments

This is one of a series of pull requests which aim to replace all instances of OwnCloudClient with NextcloudClient. The reason for this change is that the newer NextcloudClient uses OkHttp, replacing the outdated Jackrabbit methods.

Specifically, this pull request implements the following:

  • changes related to notifications
  • see #1271

ZetaTom avatar Dec 11 '23 10:12 ZetaTom

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

github-actions[bot] avatar Dec 26 '23 02:12 github-actions[bot]

Codecov Report

Attention: Patch coverage is 44.26230% with 34 lines in your changes missing coverage. Please review.

Project coverage is 49.28%. Comparing base (a5b967b) to head (f93e00f). Report is 4 commits behind head on master.

:exclamation: Current head f93e00f differs from pull request most recent head d93c23e

Please upload reports for the commit d93c23e to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1272      +/-   ##
============================================
+ Coverage     47.56%   49.28%   +1.71%     
- Complexity      977     1002      +25     
============================================
  Files           208      208              
  Lines          7850     7830      -20     
  Branches       1019     1015       -4     
============================================
+ Hits           3734     3859     +125     
+ Misses         3580     3417     -163     
- Partials        536      554      +18     
Files Coverage Δ
...tPredefinedCustomStatusMessageRemoteOperation.java 61.90% <100.00%> (ø)
.../lib/resources/users/SetStatusRemoteOperation.java 61.11% <100.00%> (-2.05%) :arrow_down:
...ib/resources/users/SetUserInfoRemoteOperation.java 85.29% <100.00%> (-2.59%) :arrow_down:
...ations/RegisterAccountDeviceForProxyOperation.java 0.00% <0.00%> (ø)
...ions/UnregisterAccountDeviceForProxyOperation.java 0.00% <0.00%> (ø)
...UserDefinedCustomStatusMessageRemoteOperation.java 65.21% <71.42%> (+1.58%) :arrow_up:
.../notifications/GetNotificationRemoteOperation.java 72.41% <50.00%> (+5.74%) :arrow_up:
...notifications/GetNotificationsRemoteOperation.java 70.37% <50.00%> (+5.85%) :arrow_up:
...cations/DeleteAllNotificationsRemoteOperation.java 55.55% <50.00%> (+55.55%) :arrow_up:
...tifications/DeleteNotificationRemoteOperation.java 60.00% <42.85%> (+60.00%) :arrow_up:
... and 2 more

... and 16 files with indirect coverage changes

codecov[bot] avatar Jan 10 '24 10:01 codecov[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

github-actions[bot] avatar Jan 30 '24 11:01 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

github-actions[bot] avatar Jun 03 '24 12:06 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

github-actions[bot] avatar Jun 10 '24 13:06 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

github-actions[bot] avatar Jun 10 '24 14:06 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

github-actions[bot] avatar Jun 10 '24 14:06 github-actions[bot]

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

github-actions[bot] avatar Jun 11 '24 05:06 github-actions[bot]