Deprecate OwncloudClient - Notifications
This is one of a series of pull requests which aim to replace all instances of OwnCloudClient with NextcloudClient. The reason for this change is that the newer NextcloudClient uses OkHttp, replacing the outdated Jackrabbit methods.
Specifically, this pull request implements the following:
- changes related to notifications
- see #1271
Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!
Codecov Report
Attention: Patch coverage is 44.26230% with 34 lines in your changes missing coverage. Please review.
Project coverage is 49.28%. Comparing base (
a5b967b) to head (f93e00f). Report is 4 commits behind head on master.
:exclamation: Current head f93e00f differs from pull request most recent head d93c23e
Please upload reports for the commit d93c23e to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #1272 +/- ##
============================================
+ Coverage 47.56% 49.28% +1.71%
- Complexity 977 1002 +25
============================================
Files 208 208
Lines 7850 7830 -20
Branches 1019 1015 -4
============================================
+ Hits 3734 3859 +125
+ Misses 3580 3417 -163
- Partials 536 554 +18
| Files | Coverage Δ | |
|---|---|---|
| ...tPredefinedCustomStatusMessageRemoteOperation.java | 61.90% <100.00%> (ø) |
|
| .../lib/resources/users/SetStatusRemoteOperation.java | 61.11% <100.00%> (-2.05%) |
:arrow_down: |
| ...ib/resources/users/SetUserInfoRemoteOperation.java | 85.29% <100.00%> (-2.59%) |
:arrow_down: |
| ...ations/RegisterAccountDeviceForProxyOperation.java | 0.00% <0.00%> (ø) |
|
| ...ions/UnregisterAccountDeviceForProxyOperation.java | 0.00% <0.00%> (ø) |
|
| ...UserDefinedCustomStatusMessageRemoteOperation.java | 65.21% <71.42%> (+1.58%) |
:arrow_up: |
| .../notifications/GetNotificationRemoteOperation.java | 72.41% <50.00%> (+5.74%) |
:arrow_up: |
| ...notifications/GetNotificationsRemoteOperation.java | 70.37% <50.00%> (+5.85%) |
:arrow_up: |
| ...cations/DeleteAllNotificationsRemoteOperation.java | 55.55% <50.00%> (+55.55%) |
:arrow_up: |
| ...tifications/DeleteNotificationRemoteOperation.java | 60.00% <42.85%> (+60.00%) |
:arrow_up: |
| ... and 2 more |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 35 | 35 |
| Correctness | 34 | 34 |
| Dodgy code | 26 | 26 |
| Internationalization | 6 | 6 |
| Malicious code vulnerability | 49 | 49 |
| Multithreaded correctness | 3 | 3 |
| Performance | 8 | 8 |
| Total | 161 | 161 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 35 | 35 |
| Correctness | 34 | 34 |
| Dodgy code | 26 | 26 |
| Internationalization | 6 | 6 |
| Malicious code vulnerability | 49 | 49 |
| Multithreaded correctness | 3 | 3 |
| Performance | 8 | 8 |
| Total | 161 | 161 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 35 | 35 |
| Correctness | 34 | 34 |
| Dodgy code | 26 | 26 |
| Internationalization | 6 | 6 |
| Malicious code vulnerability | 49 | 49 |
| Multithreaded correctness | 3 | 3 |
| Performance | 8 | 8 |
| Total | 161 | 161 |
SpotBugs
| Category | Base | New |
|---|---|---|
| Bad practice | 35 | 35 |
| Correctness | 34 | 34 |
| Dodgy code | 26 | 26 |
| Internationalization | 6 | 6 |
| Malicious code vulnerability | 49 | 49 |
| Multithreaded correctness | 3 | 3 |
| Performance | 8 | 8 |
| Total | 161 | 161 |