android-library icon indicating copy to clipboard operation
android-library copied to clipboard

Download limit for file link share

Open surinder-tsys opened this issue 2 years ago • 7 comments

Download limit related operations implementation.

PR relation: https://github.com/nextcloud/android/pull/11563

Refer: https://github.com/nextcloud/files_downloadlimit

surinder-tsys avatar May 03 '23 15:05 surinder-tsys

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

github-actions[bot] avatar May 03 '23 15:05 github-actions[bot]

Codecov Report

Merging #1123 (303d296) into master (cd15911) will increase coverage by 51.05%. The diff coverage is 34.04%.

:exclamation: Current head 303d296 differs from pull request most recent head dabcece. Consider uploading reports for the commit dabcece to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1123       +/-   ##
===========================================
+ Coverage        0   51.05%   +51.05%     
===========================================
  Files           0      191      +191     
  Lines           0     7026     +7026     
  Branches        0      940      +940     
===========================================
+ Hits            0     3587     +3587     
- Misses          0     2937     +2937     
- Partials        0      502      +502     
Impacted Files Coverage Δ
...d_limit/DeleteShareDownloadLimitRemoteOperation.kt 0.00% <0.00%> (ø)
...s/download_limit/GetShareDownloadLimitOperation.kt 0.00% <0.00%> (ø)
...esources/download_limit/ShareDownloadLimitUtils.kt 0.00% <0.00%> (ø)
...d_limit/UpdateShareDownloadLimitRemoteOperation.kt 0.00% <0.00%> (ø)
...resources/download_limit/DownloadLimitXMLParser.kt 62.37% <62.37%> (ø)
...rces/download_limit/model/DownloadLimitResponse.kt 100.00% <100.00%> (ø)

... and 185 files with indirect coverage changes

codecov[bot] avatar May 03 '23 17:05 codecov[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 34
Internationalization Warnings 6
Malicious code vulnerability Warnings 49
Multithreaded correctness Warnings 3
Performance Warnings 5
Dodgy code Warnings 27
Total 131

SpotBugs (master)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 34
Internationalization Warnings 6
Malicious code vulnerability Warnings 49
Multithreaded correctness Warnings 3
Performance Warnings 5
Dodgy code Warnings 27
Total 131

github-actions[bot] avatar Jun 08 '23 20:06 github-actions[bot]

SpotBugs (new)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 34
Internationalization Warnings 6
Malicious code vulnerability Warnings 49
Multithreaded correctness Warnings 3
Performance Warnings 5
Dodgy code Warnings 27
Total 131

SpotBugs (master)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 34
Internationalization Warnings 6
Malicious code vulnerability Warnings 49
Multithreaded correctness Warnings 3
Performance Warnings 5
Dodgy code Warnings 27
Total 131

github-actions[bot] avatar Jul 03 '23 06:07 github-actions[bot]

stable-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1992-IT-stable-07-08

nextcloud-android-bot avatar Jul 03 '23 07:07 nextcloud-android-bot

Download limit app has now a capability, which we can use: https://github.com/nextcloud/files_downloadlimit/pull/194/files#diff-d8666c6d9eaabdff763631d59b9df820f9625645a705199e82ca1844afe0eeb4R38

tobiasKaminsky avatar Oct 05 '23 07:10 tobiasKaminsky

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

github-actions[bot] avatar Feb 12 '24 22:02 github-actions[bot]