[PHP] Continuous Integration / Clean code

[docjyJ]

Is your feature request related to a problem? Please describe.

Nextcloud all in one is an old project with lots of features. The idea is to update its code by taking advantage of psalm's type checking, a new feature introduced by PHP.

Describe the solution you'd like

Use: https://github.com/nextcloud/coding-standard Go to level 1: https://psalm.dev/docs/running_psalm/error_levels/ See: https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/continuous_integration.html

Describe alternatives you've considered

Additional context

• [ ] #5307
• [ ] #5328
• [x] #5369 (before #5308)
• [ ] #5370
• [x] #5371
• [x] #5372
• [x] #5389
• [x] https://github.com/nextcloud/all-in-one/pull/5576

I will add more info to this issue when I have time.

[docjyJ]

With php 8.4 we could simplify classes to reduce code weight. The Container class could benefit greatly from this.

By using the Asymmetric Visibility: https://www.php.net/releases/8.4/en.php

ref #5699

[szaimen]

With php 8.4 we could simplify classes to reduce code weight. The Container class could benefit greatly from this.

By using the Asymmetric Visibility: https://www.php.net/releases/8.4/en.php

Looks really cool! 😍

[szaimen]

Just FYI: I just opened https://github.com/nextcloud/all-in-one/issues/5974

[szaimen]

We are finally on php 8.4 :)

[szaimen]

Hi @docjyJ any update here? Do you think we can eventually close this? From my point of view we implemented most sensible things already :)

[docjyJ]

yes we can