all-in-one icon indicating copy to clipboard operation
all-in-one copied to clipboard

Finish talk-recording geckodriver install or use chromium

Open szaimen opened this issue 1 year ago • 29 comments

Things that should be done after https://github.com/nextcloud/all-in-one/pull/2645 is finished

  • needs https://github.com/nextcloud/all-in-one/issues/3570
  • [x] ~~test if using the internal signaling IP also works~~ does not work
  • [x] ~~try if chromium works after https://github.com/nextcloud/spreed/pull/9174. If not, see below (should be available with 28)~~ not recommended

geckodriver:

  • [x] wait for https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/56841 being merged
    • [x] then change the apk add repository edge/testing to apk add repository edge/community https://github.com/nextcloud/all-in-one/pull/3907
  • [ ] wait for alpine v3.xx.1 docker image release (maybe v3.20.1?)
    • [ ] update talk image to v3.xx.1
    • [ ] then move geckodriver to normal apk add line and remove apk add repository edge/community line

szaimen avatar Jun 05 '23 14:06 szaimen

can I improve it a bit?

Zoey2936 avatar Jun 05 '23 14:06 Zoey2936

Of course :)

szaimen avatar Jun 05 '23 14:06 szaimen

btw, I would wait with the request to move it out of testing until we actually confirmed that it works ...

szaimen avatar Jun 05 '23 14:06 szaimen

Possibly we could alternatively as soon as chromium support comes with https://github.com/nextcloud/spreed/pull/9174 switch to that...

szaimen avatar Jun 05 '23 15:06 szaimen

are there differences between chromium and firefox?

Zoey2936 avatar Jun 05 '23 15:06 Zoey2936

are there differences between chromium and firefox?

I don't know honestly... Possibly RAM and CPU usage could be different...

szaimen avatar Jun 05 '23 15:06 szaimen

So apparently the recording server is reachable but it does not record. I get these logs now in the geckodriver.log:

console.warn: services.settings: Ignoring preference override of remote settings server
console.warn: services.settings: Allow by setting MOZ_REMOTE_SETTINGS_DEVTOOLS=1 in the environment
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: glxtest: libEGL initialize failed (t=1.40348) [GFX1-]: glxtest: libEGL initialize failed
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: glxtest: libEGL initialize failed (t=1.40348) |[1][GFX1-]: glxtest: GLX extension missing (t=1.40355) [GFX1-]: glxtest: GLX extension missing
1686043005688   Marionette      INFO    Marionette enabled
1686043005695   Marionette      INFO    Listening on port 35609
Read port: 35609
console.error: "Warning: unrecognized command line flag -width\n"
console.error: "Warning: unrecognized command line flag -height\n"
WebDriver BiDi listening on ws://127.0.0.1:41207
1686043006011   RemoteAgent     WARN    TLS certificate errors will be ignored for this session
console.error: ({})
DevTools listening on ws://127.0.0.1:41207/devtools/browser/a8bb929e-2b73-4c8e-99ab-2356c14d4c12
1686043008674   RemoteAgent     INFO    Perform WebSocket upgrade for incoming connection from 127.0.0.1:50114
1686043030725   Marionette      INFO    Stopped listening on port 35609
console.error:
  NotFoundError: No such JSProcessActor 'WebDriverProcessData': get processActor@chrome://remote/content/webdriver-bidi/modules/WindowGlobalBiDiModule.sys.mjs:16:40
get nodeCache@chrome://remote/content/webdriver-bidi/modules/WindowGlobalBiDiModule.sys.mjs:12:5
#onConsoleAPIMessage@chrome://remote/content/webdriver-bidi/modules/windowglobal/log.sys.mjs:141:23
emit@resource://gre/modules/EventEmitter.sys.mjs:154:20
#onConsoleAPIMessage@chrome://remote/content/shared/listeners/ConsoleAPIListener.sys.mjs:119:10
CS_recordEvent@resource://gre/modules/ConsoleAPIStorage.jsm:172:19
beforeMount/e/</<@https://aio-testing.nextcloud.com/custom_apps/spreed/js/talk-recording.js?v=959ec500-0:2:6003429

JavaScript error: resource://gre/actors/AudioPlaybackChild.sys.mjs, line 17: InvalidStateError: JSWindowActorChild.sendAsyncMessage: JSWindowActorChild cannot send at the moment
1686043167629   geckodriver     INFO    Listening on 127.0.0.1:52471
1686043168199   mozrunner::runner       INFO    Running command: MOZ_CRASHREPORTER="1" MOZ_CRASHREPORTER_NO_REPORT="1" MOZ_CRASHREPORTER_SHUTDOWN="1" MOZ_NO_REMOTE="1" "/usr ... 80" "--remote-debugging-port" "54207" "--remote-allow-hosts" "localhost" "-no-remote" "-profile" "/tmp/rust_mozprofile3Dj5sQ"
console.warn: services.settings: Ignoring preference override of remote settings server
console.warn: services.settings: Allow by setting MOZ_REMOTE_SETTINGS_DEVTOOLS=1 in the environment
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: glxtest: libEGL initialize failed (t=0.74969) [GFX1-]: glxtest: libEGL initialize failed
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: glxtest: libEGL initialize failed (t=0.74969) |[1][GFX1-]: glxtest: GLX extension missing (t=0.749767) [GFX1-]: glxtest: GLX extension missing
1686043168976   Marionette      INFO    Marionette enabled
1686043168982   Marionette      INFO    Listening on port 36985
Read port: 36985
console.error: "Warning: unrecognized command line flag -width\n"
console.error: "Warning: unrecognized command line flag -height\n"
WebDriver BiDi listening on ws://127.0.0.1:54207
1686043169281   RemoteAgent     WARN    TLS certificate errors will be ignored for this session
console.error: ({})
DevTools listening on ws://127.0.0.1:54207/devtools/browser/7a770e78-012d-4aa4-a3ec-4a1359d706a8
1686043171888   RemoteAgent     INFO    Perform WebSocket upgrade for incoming connection from 127.0.0.1:54722
console.error: "update.locale" " file doesn't exist in either the application or GRE directories"
1686043214274   Marionette      INFO    Stopped listening on port 36985
console.error:
  NotFoundError: No such JSProcessActor 'WebDriverProcessData': get processActor@chrome://remote/content/webdriver-bidi/modules/WindowGlobalBiDiModule.sys.mjs:16:40
get nodeCache@chrome://remote/content/webdriver-bidi/modules/WindowGlobalBiDiModule.sys.mjs:12:5
#onConsoleAPIMessage@chrome://remote/content/webdriver-bidi/modules/windowglobal/log.sys.mjs:141:23
emit@resource://gre/modules/EventEmitter.sys.mjs:154:20
#onConsoleAPIMessage@chrome://remote/content/shared/listeners/ConsoleAPIListener.sys.mjs:119:10
CS_recordEvent@resource://gre/modules/ConsoleAPIStorage.jsm:172:19
beforeMount/e/</<@https://aio-testing.nextcloud.com/custom_apps/spreed/js/talk-recording.js?v=959ec500-0:2:6003429

JavaScript error: resource://gre/actors/AudioPlaybackChild.sys.mjs, line 17: InvalidStateError: JSWindowActorChild.sendAsyncMessage: JSWindowActorChild cannot send at the moment
1686047078339   geckodriver     INFO    Listening on 127.0.0.1:38513
1686047079059   mozrunner::runner       INFO    Running command: MOZ_CRASHREPORTER="1" MOZ_CRASHREPORTER_NO_REPORT="1" MOZ_CRASHREPORTER_SHUTDOWN="1" MOZ_NO_REMOTE="1" "/usr ... 80" "--remote-debugging-port" "41129" "--remote-allow-hosts" "localhost" "-no-remote" "-profile" "/tmp/rust_mozprofile6pSYel"
console.warn: services.settings: Ignoring preference override of remote settings server
console.warn: services.settings: Allow by setting MOZ_REMOTE_SETTINGS_DEVTOOLS=1 in the environment
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: glxtest: libEGL initialize failed (t=1.2704) [GFX1-]: glxtest: libEGL initialize failed
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: glxtest: libEGL initialize failed (t=1.2704) |[1][GFX1-]: glxtest: GLX extension missing (t=1.2705) [GFX1-]: glxtest: GLX extension missing
1686047080375   Marionette      INFO    Marionette enabled
1686047080383   Marionette      INFO    Listening on port 37983
Read port: 37983
console.error: "Warning: unrecognized command line flag -width\n"
console.error: "Warning: unrecognized command line flag -height\n"
WebDriver BiDi listening on ws://127.0.0.1:41129
1686047080675   RemoteAgent     WARN    TLS certificate errors will be ignored for this session
console.error: ({})
DevTools listening on ws://127.0.0.1:41129/devtools/browser/dbe88ebe-219c-4d84-8112-71685a49afcb
1686047083120   RemoteAgent     INFO    Perform WebSocket upgrade for incoming connection from 127.0.0.1:47140
console.error: "update.locale" " file doesn't exist in either the application or GRE directories"
1686047126038   Marionette      INFO    Stopped listening on port 37983
console.error:
  NotFoundError: No such JSProcessActor 'WebDriverProcessData': get processActor@chrome://remote/content/webdriver-bidi/modules/WindowGlobalBiDiModule.sys.mjs:16:40
get nodeCache@chrome://remote/content/webdriver-bidi/modules/WindowGlobalBiDiModule.sys.mjs:12:5
#onConsoleAPIMessage@chrome://remote/content/webdriver-bidi/modules/windowglobal/log.sys.mjs:141:23
emit@resource://gre/modules/EventEmitter.sys.mjs:154:20
#onConsoleAPIMessage@chrome://remote/content/shared/listeners/ConsoleAPIListener.sys.mjs:119:10
CS_recordEvent@resource://gre/modules/ConsoleAPIStorage.jsm:172:19
beforeMount/e/</<@https://aio-testing.nextcloud.com/custom_apps/spreed/js/talk-recording.js?v=959ec500-0:2:6003429

szaimen avatar Jun 06 '23 10:06 szaimen

Apparently the logs are unrelated. The recording worked nonetheless. But it was not automatically shared into the conversation, I only got a notification.

szaimen avatar Jun 06 '23 10:06 szaimen

  • test if using the internal signaling IP also works

Does not work

szaimen avatar Jun 06 '23 10:06 szaimen

Apparently the logs are unrelated. The recording worked nonetheless. But it was not automatically shared into the conversation, I only got a notification.

so it works?

Zoey2936 avatar Jun 06 '23 10:06 Zoey2936

so it works?

yes :)

szaimen avatar Jun 06 '23 10:06 szaimen

do you now create the issue on the aports??

Zoey2936 avatar Jun 06 '23 14:06 Zoey2936

do you now create the issue on the aports??

Ah yes, almost forgot

szaimen avatar Jun 06 '23 14:06 szaimen

https://gitlab.alpinelinux.org/alpine/aports/-/issues/14997

szaimen avatar Jun 06 '23 14:06 szaimen

The issue was closed... So what do you to do now? do you want to switch to chrome then or should I ask if I can take over the maintance of geckodriver?

Zoey2936 avatar Jun 09 '23 04:06 Zoey2936

The issue was closed... So what do you to do now? do you want to switch to chrome then or should I ask if I can take over the maintance of geckodriver?

I would say lets wait for https://github.com/nextcloud/spreed/pull/9174 to be merged and released. Then update the container to use chromium. If this works, I would say maintaining upstream geckodriver is not needed. If we cannot make it work with chromium then we can think about further steps. And thanks for the huge offer to take over the maintance of geckodriver btw! :)

szaimen avatar Jun 09 '23 08:06 szaimen

It seem there are some blockers for using chromium: https://github.com/nextcloud/spreed/pull/9177#issuecomment-1667664311

szaimen avatar Aug 10 '23 15:08 szaimen

It seem there are some blockers for using chromium: nextcloud/spreed#9177 (comment)

it's now merged ;-)

jospoortvliet avatar Nov 15 '23 02:11 jospoortvliet

While chromium recording is there, it is not the recommended solution

nickvergessen avatar Nov 16 '23 10:11 nickvergessen

While chromium recording is there, it is not the recommended solution

I see. In that case, @Zoey2936, you offered a few comments above that you could take over the maintainership of the geckodriver package in alpine aports. Is that still the case?

szaimen avatar Nov 16 '23 10:11 szaimen

yes

Zoey2936 avatar Nov 18 '23 11:11 Zoey2936

I've created https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/56841

Zoey2936 avatar Dec 07 '23 22:12 Zoey2936

@szaimen can you please change the apk add line?

Zoey2936 avatar Dec 08 '23 12:12 Zoey2936

@szaimen can you please change the apk add line?

Will it be already available now or do we need to wait e.g. for Alpine 3.19.1?

szaimen avatar Dec 08 '23 13:12 szaimen

I think 3.20.0

Zoey2936 avatar Dec 08 '23 13:12 Zoey2936

I think 3.20.0

Okay, then I'd say lets wait for that

szaimen avatar Dec 08 '23 13:12 szaimen

Yes but it moved from testing to community, so this needs to be changed in the apk add line

Zoey2936 avatar Dec 08 '23 13:12 Zoey2936

Yes but it moved from testing to community, so this needs to be changed in the apk add line

Okay, so we can already change that now or do we still need to wait for 3.19.1 for this to become available?

szaimen avatar Dec 08 '23 13:12 szaimen

We still need to pull it from edge, but from the community branch now

Zoey2936 avatar Dec 08 '23 14:12 Zoey2936

alpine v3.20.1 was released

Zoey2936 avatar Jun 20 '24 19:06 Zoey2936