activity icon indicating copy to clipboard operation
activity copied to clipboard

[BITV] Accessibility issues

Open PVince81 opened this issue 2 years ago • 3 comments

Bug fixes

  • [ ] Full date can be shown after headings like "Today" as a hidden-visually span
  • [ ] List of activities should be marked up as <ul> unordered list with <li> elements
  • [ ] Better to use underline for hover/focus style of the links
  • [ ] Clicking on a file should ideally open the image or file in place

Follow up features

  • [ ] Lazy loading not accessible as you can not move very far to the past quickly. Pagination would be much better here
  • [ ] Also, navigation via months/time could be useful
  • [ ] Filtering/search would be useful

PVince81 avatar Aug 29 '22 20:08 PVince81

Better to use underline for hover/focus style of the links

Since activity is not reverting a server rule there, would it make sense to do this on a global level? Otherwise we also need to track this for all the links in settings descriptions, notifications, ...

nickvergessen avatar Aug 30 '22 06:08 nickvergessen

Lazy loading not accessible as you can not move very far to the past quickly.

You can't anyway as the responses are rather slow and only get 30 entries per grab (could increase that now that the server load was improved with nextcloud/activity#871

I split the issue list into "bug fixes" which we should do now and "follow up features" which can be done later. Let me know if you agree.

nickvergessen avatar Aug 30 '22 07:08 nickvergessen

yeah, lazy loading / moving to pagination is going to be a bigger challenge in multiple fronts anyway...

PVince81 avatar Aug 31 '22 09:08 PVince81

Clicking on a file should ideally open the image or file in place

Isn't this a feature as well?

ChristophWurst avatar Nov 30 '22 16:11 ChristophWurst

yes, I've edited and moved it to features

PVince81 avatar Dec 01 '22 08:12 PVince81

Better to use underline for hover/focus style of the links

That should be applied to all Nextcloud? Or what makes it valid here, but e.g. not in notifications etc?

nickvergessen avatar Dec 01 '22 09:12 nickvergessen

  • [x] Better to use underline for hover/focus style of the links => Already have as issue

JuliaKirschenheuter avatar Dec 01 '22 09:12 JuliaKirschenheuter

Please check if some of the issues might be fixed by nextcloud/activity#1043.

st3iny avatar Jan 03 '23 11:01 st3iny

[ ] Clicking on a file should ideally open the image or file in place: right now a redirection to files takes place. File will be opened "in place".

@michaelnissenbaum is this approach ok to you?

JuliaKirschenheuter avatar Feb 09 '23 11:02 JuliaKirschenheuter

@JuliaKirschenheuter If by 'open in place' you mean that the image/file will be opened on the same page in a viewer/editor, then that's acceptable to me. It's important that the editor/viewer is fully accessible. Additionally, please ensure that once a file or image is opened, the keyboard focus is properly placed and clearly visible.

michaelnissenbaum avatar Mar 02 '23 08:03 michaelnissenbaum