activity icon indicating copy to clipboard operation
activity copied to clipboard

add debug output and missing exception handlers to fix #459

Open madmas opened this issue 5 years ago • 5 comments

add debug outout and exception handling fix to get rid of over-and-over sent notifications.

I think esp. the changes to line 410 helped to fix the issue.

madmas avatar May 06 '20 16:05 madmas

How does logException fixes something? Mind to share $e->getMessage() to see why sending the email failed?

kesselb avatar Jun 17 '20 22:06 kesselb

Hi @kesselb , sorry, I switched the lines, I think the actual fix is below, in line 415. 410 of course only helps in regard of debugging ;-)

madmas avatar Jun 24 '20 10:06 madmas

Mind to share the exception? Also you overwrite the actual exception message. That makes it harder to debug.

kesselb avatar Jun 24 '20 10:06 kesselb

I'm not convinced. ~Right now the error handling code fails and~ the original exception message is replaced with a generic error message.

My experience was vice versa - with the output I added with shown here, I got much more details. I cannot share the exception as after implementing this, I don't see them happen on my system anymore....

madmas avatar Jun 26 '20 13:06 madmas

We still don't know why sending the notification failed in the first place. This is fixing symptoms not problems 😟

kesselb avatar Jun 26 '20 14:06 kesselb